From issues-return-22367-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Sat Dec 8 06:02:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9C06818067E for ; Sat, 8 Dec 2018 06:02:58 +0100 (CET) Received: (qmail 17710 invoked by uid 500); 8 Dec 2018 05:02:57 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 17697 invoked by uid 99); 8 Dec 2018 05:02:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Dec 2018 05:02:57 +0000 From: GitBox To: issues@kylin.apache.org Subject: [GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell Message-ID: <154424537692.32701.16479948971021775954.gitbox@gitbox.apache.org> Date: Sat, 08 Dec 2018 05:02:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3921](https://coveralls.io/builds/20502981) * **9** of **65** **(13.85%)** changed or added relevant lines in **9** files are covered. * **193** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.005%**) to **25.939%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 2 | 3 | 66.67% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502981/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L63) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 5 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20502981/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 29 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20502981/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502981/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L68) | 4 | 0.0% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 41 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L178) | 65 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 79 | 0.0% | | Totals | [![Coverage Status](https://coveralls.io/builds/20502981/badge)](https://coveralls.io/builds/20502981) | | :-- | --: | | Change from base [Build 3920](https://coveralls.io/builds/20502796): | -0.005% | | Covered Lines: | 17692 | | Relevant Lines: | 68207 | --- ##### 💛 - [Coveralls](https://coveralls.io) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services