From issues-return-22244-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Wed Dec 5 06:53:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D37FC18067A for ; Wed, 5 Dec 2018 06:52:59 +0100 (CET) Received: (qmail 84167 invoked by uid 500); 5 Dec 2018 05:52:59 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 84152 invoked by uid 99); 5 Dec 2018 05:52:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2018 05:52:58 +0000 From: GitBox To: issues@kylin.apache.org Subject: [GitHub] codecov-io commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b) Message-ID: <154398917841.27023.86999827559943630.gitbox@gitbox.apache.org> Date: Wed, 05 Dec 2018 05:52:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b) URL: https://github.com/apache/kylin/pull/371#issuecomment-444367864 # [Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=h1) Report > Merging [#371](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/be5df4a8bb6939c0c62c6135c4312fe3ad56775d?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/371/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #371 +/- ## ============================================ - Coverage 23.64% 23.63% -0.02% + Complexity 4838 4837 -1 ============================================ Files 1131 1131 Lines 68193 68193 Branches 9684 9684 ============================================ - Hits 16124 16116 -8 - Misses 50503 50509 +6 - Partials 1566 1568 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=footer). Last update [be5df4a...a073222](https://codecov.io/gh/apache/kylin/pull/371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services