From issues-return-21545-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Nov 6 16:15:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B265C18067E for ; Tue, 6 Nov 2018 16:15:04 +0100 (CET) Received: (qmail 55266 invoked by uid 500); 6 Nov 2018 15:15:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 55205 invoked by uid 99); 6 Nov 2018 15:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2018 15:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 686F2C2299 for ; Tue, 6 Nov 2018 15:15:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Eyj49AZqezZO for ; Tue, 6 Nov 2018 15:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 642335F32E for ; Tue, 6 Nov 2018 15:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8BD68E00EA for ; Tue, 6 Nov 2018 15:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2D77B2669F for ; Tue, 6 Nov 2018 15:15:00 +0000 (UTC) Date: Tue, 6 Nov 2018 15:15:00 +0000 (UTC) From: "Jiatao Tao (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KYLIN-3669) Add logs to GTStreamAggregateScanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated KYLIN-3669: ------------------------------ Description: There's no log printing in GTStreamAggregateScanner, and you know nothing about whether you go to this path or not, it's pretty unfriendly for trouble shooting. Code in _SegmentCubeTupleIterator_. {code:java} boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator; if (hasMultiplePartitions && context.isStreamAggregateEnabled()) { ... // input records are ordered, leverage stream aggregator to produce possibly fewer records try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner, scanRequest)) { result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx); } catch (IOException ioe) { // implementation of close method of anonymous IGTScanner is empty, no way throw exception throw new IllegalStateException("IOException is not expected here.", ioe); } return result; } {code} was: There's no log printing in GTStreamAggregateScanner, and you know nothing about whether you go to this path or not, it's pretty unfriendly for trouble shooting. Code in _SegmentCubeTupleIterator_. {code:java} boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator; if (hasMultiplePartitions && context.isStreamAggregateEnabled()) { // input records are ordered, leverage stream aggregator to produce possibly fewer records IGTScanner inputScanner = new IGTScanner() { public GTInfo getInfo() { return scanRequest.getInfo(); } public void close() { // Underlying resource is hold by scanner and it will be closed at // SegmentCubeTupleIterator#close, caller is SequentialCubeTupleIterator } public Iterator iterator() { return records; } }; Iterator result; try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner, scanRequest)) { result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx); } catch (IOException ioe) { // implementation of close method of anonymous IGTScanner is empty, no way throw exception throw new IllegalStateException("IOException is not expected here.", ioe); } return result; } {code} > Add logs to GTStreamAggregateScanner > ------------------------------------ > > Key: KYLIN-3669 > URL: https://issues.apache.org/jira/browse/KYLIN-3669 > Project: Kylin > Issue Type: Improvement > Components: Query Engine > Reporter: Jiatao Tao > Assignee: Jiatao Tao > Priority: Trivial > > There's no log printing in GTStreamAggregateScanner, and you know nothing about whether you go to this path or not, it's pretty unfriendly for trouble shooting. > Code in _SegmentCubeTupleIterator_. > {code:java} > boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator; > if (hasMultiplePartitions && context.isStreamAggregateEnabled()) { > ... > // input records are ordered, leverage stream aggregator to produce possibly fewer records > try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner, scanRequest)) { > result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx); > } catch (IOException ioe) { > // implementation of close method of anonymous IGTScanner is empty, no way throw exception > throw new IllegalStateException("IOException is not expected here.", ioe); > } > return result; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)