From issues-return-22024-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Nov 27 02:41:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0E94180677 for ; Tue, 27 Nov 2018 02:41:04 +0100 (CET) Received: (qmail 7967 invoked by uid 500); 27 Nov 2018 01:41:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 7951 invoked by uid 99); 27 Nov 2018 01:41:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 01:41:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 82A77C05DD for ; Tue, 27 Nov 2018 01:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BBbrQWRsj1er for ; Tue, 27 Nov 2018 01:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 512DB60CF3 for ; Tue, 27 Nov 2018 01:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D301FE02EB for ; Tue, 27 Nov 2018 01:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8514621095 for ; Tue, 27 Nov 2018 01:41:00 +0000 (UTC) Date: Tue, 27 Nov 2018 01:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3665) Partition time column may never be added MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3665?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1669= 9802#comment-16699802 ]=20 ASF GitHub Bot commented on KYLIN-3665: --------------------------------------- Wayne1c closed pull request #356: KYLIN-3665 Partition time column may neve= r be used URL: https://github.com/apache/kylin/pull/356 =20 =20 =20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Pa= rtitionDesc.java b/core-metadata/src/main/java/org/apache/kylin/metadata/mo= del/PartitionDesc.java index dcb37ecdad..47802d9831 100644 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Partition= Desc.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/Partition= Desc.java @@ -95,6 +95,14 @@ public boolean partitionColumnIsTimeMillis() { return type.isBigInt() && !DateFormat.isDatePattern(partitionDateF= ormat); } =20 + public boolean partitionTimeColumnIsInt() { + if (partitionTimeColumnRef =3D=3D null) + return false; + + DataType type =3D partitionTimeColumnRef.getType(); + return (type.isInt() || type.isBigInt()); + } + public boolean isPartitioned() { return partitionDateColumnRef !=3D null; } @@ -194,103 +202,99 @@ public String buildDateRangeCondition(PartitionDesc = partDesc, ISegment seg, Segm long startInclusive =3D (Long) segRange.start.v; long endExclusive =3D (Long) segRange.end.v; =20 + if (endExclusive <=3D startInclusive) { + return "1=3D0"; + } + TblColRef partitionDateColumn =3D partDesc.getPartitionDateCol= umnRef(); TblColRef partitionTimeColumn =3D partDesc.getPartitionTimeCol= umnRef(); =20 StringBuilder builder =3D new StringBuilder(); =20 - if (partDesc.partitionColumnIsYmdInt()) { - buildSingleColumnRangeCondAsYmdInt(builder, partitionDateC= olumn, startInclusive, endExclusive, - partDesc.getPartitionDateFormat()); - } else if (partDesc.partitionColumnIsTimeMillis()) { - buildSingleColumnRangeCondAsTimeMillis(builder, partitionD= ateColumn, startInclusive, endExclusive); - } else if (partitionDateColumn !=3D null && partitionTimeColum= n =3D=3D null) { - buildSingleColumnRangeCondition(builder, partitionDateColu= mn, startInclusive, endExclusive, - partDesc.getPartitionDateFormat()); - } else if (partitionDateColumn =3D=3D null && partitionTimeCol= umn !=3D null) { - buildSingleColumnRangeCondition(builder, partitionTimeColu= mn, startInclusive, endExclusive, - partDesc.getPartitionTimeFormat()); - } else if (partitionDateColumn !=3D null && partitionTimeColum= n !=3D null) { - buildMultipleColumnRangeCondition(builder, partitionDateCo= lumn, partitionTimeColumn, startInclusive, - endExclusive, partDesc.getPartitionDateFormat(), p= artDesc.getPartitionTimeFormat()); + if (partitionDateColumn !=3D null && partitionTimeColumn !=3D = null) { + buildMultipleColumnRangeCondition(builder, partitionDateCo= lumn, partitionTimeColumn, startInclusive, endExclusive, partDesc); + } else if (partitionDateColumn !=3D null) { + buildSingleColumnRangeCondition(builder, partitionDateColu= mn, startInclusive, endExclusive, partDesc, true); + } else if (partitionTimeColumn !=3D null) { + buildSingleColumnRangeCondition(builder, partitionTimeColu= mn, startInclusive, endExclusive, partDesc, false); } =20 return builder.toString(); } =20 - private static void buildSingleColumnRangeCondAsTimeMillis(StringB= uilder builder, TblColRef partitionColumn, - long startInclusive, long endExclusive) { - String partitionColumnName =3D partitionColumn.getIdentity(); - builder.append(partitionColumnName + " >=3D " + startInclusive= ); - builder.append(" AND "); - builder.append(partitionColumnName + " < " + endExclusive); - } - - private static void buildSingleColumnRangeCondAsYmdInt(StringBuild= er builder, TblColRef partitionColumn, - long startInclusive, long endExclusive, String partitionCo= lumnDateFormat) { - String partitionColumnName =3D partitionColumn.getIdentity(); - builder.append(partitionColumnName + " >=3D " - + DateFormat.formatToDateStr(startInclusive, partition= ColumnDateFormat)); - builder.append(" AND "); - builder.append( - partitionColumnName + " < " + DateFormat.formatToDateS= tr(endExclusive, partitionColumnDateFormat)); - } - private static void buildSingleColumnRangeCondition(StringBuilder = builder, TblColRef partitionColumn, - long startInclusive, long endExclusive, String partitionCo= lumnDateFormat) { + long startInclusive, long endExclusive, PartitionDesc part= itionDesc, boolean isPartitionDateColumn) { String partitionColumnName =3D partitionColumn.getIdentity(); =20 - if (endExclusive <=3D startInclusive) { - builder.append("1=3D0"); - return; - } - String startInc =3D null; String endInc =3D null; - if (StringUtils.isBlank(partitionColumnDateFormat)) { - startInc =3D String.valueOf(startInclusive); - endInc =3D String.valueOf(endExclusive); + + if (isPartitionDateColumn) { + startInc =3D convertDateConditionValue(startInclusive, par= titionDesc); + endInc =3D convertDateConditionValue(endExclusive, partiti= onDesc); } else { - startInc =3D DateFormat.formatToDateStr(startInclusive, pa= rtitionColumnDateFormat); - endInc =3D DateFormat.formatToDateStr(endExclusive, partit= ionColumnDateFormat); + startInc =3D convertTimeConditionValue(startInclusive, par= titionDesc); + endInc =3D convertTimeConditionValue(endExclusive, partiti= onDesc); } =20 - builder.append(partitionColumnName + " >=3D '" + startInc + "'= "); + builder.append(partitionColumnName + " >=3D " + startInc); builder.append(" AND "); - builder.append(partitionColumnName + " < '" + endInc + "'"); + builder.append(partitionColumnName + " < " + endInc); + } + + private static String convertDateConditionValue(long date, Partiti= onDesc partitionDesc) { + if(partitionDesc.partitionColumnIsYmdInt()) { + return DateFormat.formatToDateStr(date, partitionDesc.getP= artitionDateFormat()); + } else if (partitionDesc.partitionColumnIsTimeMillis()) { + return String.valueOf(date); + } else { + return "'" + DateFormat.formatToDateStr(date, partitionDes= c.getPartitionDateFormat()) + "'"; + } + } + + private static String convertTimeConditionValue(long time, Partiti= onDesc partitionDesc) { + //currently supported time format: HH:mm:ss=E3=80=81HH:mm=E3= =80=81HH(String/int) + //TODO: HHmmss=E3=80=81HHmm(String/int) + + if (partitionDesc.partitionTimeColumnIsInt()) { + return DateFormat.formatToDateStr(time, partitionDesc.getP= artitionTimeFormat()); + } else { + return "'" + DateFormat.formatToDateStr(time, partitionDes= c.getPartitionTimeFormat()) + "'"; + } } =20 private static void buildMultipleColumnRangeCondition(StringBuilde= r builder, TblColRef partitionDateColumn, - TblColRef partitionTimeColumn, long startInclusive, long e= ndExclusive, String partitionColumnDateFormat, - String partitionColumnTimeFormat) { + TblColRef partitionTimeColumn, long startInclusive, long e= ndExclusive, PartitionDesc partitionDesc) { String partitionDateColumnName =3D partitionDateColumn.getIden= tity(); String partitionTimeColumnName =3D partitionTimeColumn.getIden= tity(); + + String conditionDateStartValue =3D convertDateConditionValue(s= tartInclusive, partitionDesc); + String conditionDateEndValue =3D convertDateConditionValue(end= Exclusive, partitionDesc); + + String conditionTimeStartValue =3D convertTimeConditionValue(s= tartInclusive, partitionDesc); + String conditionTimeEndValue =3D convertTimeConditionValue(end= Exclusive, partitionDesc); + builder.append("("); builder.append("("); - builder.append(partitionDateColumnName + " =3D '" - + DateFormat.formatToDateStr(startInclusive, partition= ColumnDateFormat) + "'").append(" AND ") - .append(partitionTimeColumnName + " >=3D '" - + DateFormat.formatToDateStr(startInclusive, p= artitionColumnTimeFormat) + "'"); + builder.append(partitionDateColumnName + " =3D " + conditionDa= teStartValue).append(" AND ") + .append(partitionTimeColumnName + " >=3D " + condition= TimeStartValue); builder.append(")"); builder.append(" OR "); builder.append("("); - builder.append(partitionDateColumnName + " > '" - + DateFormat.formatToDateStr(startInclusive, partition= ColumnDateFormat) + "'"); + builder.append(partitionDateColumnName + " > " + conditionDate= StartValue); builder.append(")"); builder.append(")"); + builder.append(" AND "); =20 builder.append("("); builder.append("("); - builder.append(partitionDateColumnName + " =3D '" - + DateFormat.formatToDateStr(endExclusive, partitionCo= lumnDateFormat) + "'").append(" AND ") - .append(partitionTimeColumnName + " < '" - + DateFormat.formatToDateStr(endExclusive, par= titionColumnTimeFormat) + "'"); + builder.append(partitionDateColumnName + " =3D " + conditionDa= teEndValue).append(" AND ") + .append(partitionTimeColumnName + " < " + conditionTim= eEndValue); builder.append(")"); builder.append(" OR "); builder.append("("); - builder.append(partitionDateColumnName + " < '" - + DateFormat.formatToDateStr(endExclusive, partitionCo= lumnDateFormat) + "'"); + builder.append(partitionDateColumnName + " < " + conditionDate= EndValue); builder.append(")"); builder.append(")"); } diff --git a/core-metadata/src/test/java/org/apache/kylin/metadata/model/De= faultPartitionConditionBuilderTest.java b/core-metadata/src/test/java/org/a= pache/kylin/metadata/model/DefaultPartitionConditionBuilderTest.java index b536e29191..403c2f85c1 100644 --- a/core-metadata/src/test/java/org/apache/kylin/metadata/model/DefaultPa= rtitionConditionBuilderTest.java +++ b/core-metadata/src/test/java/org/apache/kylin/metadata/model/DefaultPa= rtitionConditionBuilderTest.java @@ -51,47 +51,139 @@ public void testDatePartition() { TblColRef col =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABLE= _NAME"), 1, "DATE_COLUMN", "string"); partitionDesc.setPartitionDateColumnRef(col); partitionDesc.setPartitionDateColumn(col.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2"), DateFormat.stringToMillis("2016-02-23 21:32:29")); + String condition; + partitionDesc.setPartitionDateFormat("yyyy-MM-dd"); - TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2"), DateFormat.stringToMillis("2016-02-23")); - String condition =3D partitionConditionBuilder.buildDateRangeCondi= tion(partitionDesc, null, range); - Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D '2016-02-22' A= ND UNKNOWN_ALIAS.DATE_COLUMN < '2016-02-23'", - condition); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D '2016-02-22' A= ND UNKNOWN_ALIAS.DATE_COLUMN < '2016-02-23'", condition); + + partitionDesc.setPartitionDateFormat("yyyy-MM-dd HH:mm"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D '2016-02-22 00= :00' AND UNKNOWN_ALIAS.DATE_COLUMN < '2016-02-23 21:32'", condition); + + partitionDesc.setPartitionDateFormat("yyyyMMddHH"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D '2016022200' A= ND UNKNOWN_ALIAS.DATE_COLUMN < '2016022321'", condition); + + partitionDesc.setPartitionDateFormat("yyyyMMddHHmm"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D '201602220000'= AND UNKNOWN_ALIAS.DATE_COLUMN < '201602232132'", condition); =20 range =3D new TSRange(0L, 0L); condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); Assert.assertEquals("1=3D0", condition); } =20 + @Test + public void testDatePartitionYmdInt() { + PartitionDesc partitionDesc =3D new PartitionDesc(); + TblColRef col =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABLE= _NAME"), 1, "DATE_COLUMN", "integer"); + partitionDesc.setPartitionDateColumnRef(col); + partitionDesc.setPartitionDateColumn(col.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2"), DateFormat.stringToMillis("2016-02-23 20:32:29")); + String condition; + + partitionDesc.setPartitionDateFormat("yyyyMMdd"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D 20160222 AND U= NKNOWN_ALIAS.DATE_COLUMN < 20160223", condition); + + partitionDesc.setPartitionDateFormat("yyyyMMddHHmmss"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D 20160222000000= AND UNKNOWN_ALIAS.DATE_COLUMN < 20160223203229", condition); + } + + @Test + public void testDatePartitionTimeMillis() { + PartitionDesc partitionDesc =3D new PartitionDesc(); + TblColRef col =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABLE= _NAME"), 1, "DATE_COLUMN", "bigint"); + partitionDesc.setPartitionDateColumnRef(col); + partitionDesc.setPartitionDateColumn(col.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2"), DateFormat.stringToMillis("2016-02-23 20:32:29")); + String condition; + + partitionDesc.setPartitionDateFormat("yyyy-MM-dd HH:mm:ss"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.DATE_COLUMN >=3D 1456099200000 = AND UNKNOWN_ALIAS.DATE_COLUMN < 1456259549000", condition); + } + @Test public void testTimePartition() { PartitionDesc partitionDesc =3D new PartitionDesc(); TblColRef col =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABLE= _NAME"), 2, "HOUR_COLUMN", "string"); partitionDesc.setPartitionTimeColumnRef(col); partitionDesc.setPartitionTimeColumn(col.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 00:12:00"), DateFormat.stringToMillis("2016-02-23 01:00:00")); + String condition; + partitionDesc.setPartitionTimeFormat("HH"); - TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 00:00:00"), - DateFormat.stringToMillis("2016-02-23 01:00:00")); - String condition =3D partitionConditionBuilder.buildDateRangeCondi= tion(partitionDesc, null, range); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); Assert.assertEquals("UNKNOWN_ALIAS.HOUR_COLUMN >=3D '00' AND UNKNO= WN_ALIAS.HOUR_COLUMN < '01'", condition); + + partitionDesc.setPartitionTimeFormat("HH:mm"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.HOUR_COLUMN >=3D '00:12' AND UN= KNOWN_ALIAS.HOUR_COLUMN < '01:00'", condition); } =20 @Test - public void testDateAndTimePartition() { + public void testTimePartitionIsInt() { + PartitionDesc partitionDesc =3D new PartitionDesc(); + TblColRef col =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABLE= _NAME"), 2, "HOUR_COLUMN", "integer"); + partitionDesc.setPartitionTimeColumnRef(col); + partitionDesc.setPartitionTimeColumn(col.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 19:12:00"), DateFormat.stringToMillis("2016-02-23 20:00:00")); + String condition; + + partitionDesc.setPartitionTimeFormat("HH"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals("UNKNOWN_ALIAS.HOUR_COLUMN >=3D 19 AND UNKNOWN= _ALIAS.HOUR_COLUMN < 20", condition); + } + + @Test + public void testDateAndTimePartitionString() { PartitionDesc partitionDesc =3D new PartitionDesc(); TblColRef col1 =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABL= E_NAME"), 1, "DATE_COLUMN", "string"); partitionDesc.setPartitionDateColumnRef(col1); partitionDesc.setPartitionDateColumn(col1.getCanonicalName()); - partitionDesc.setPartitionDateFormat("yyyy-MM-dd"); TblColRef col2 =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABL= E_NAME"), 2, "HOUR_COLUMN", "string"); partitionDesc.setPartitionTimeColumnRef(col2); partitionDesc.setPartitionTimeColumn(col2.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 00:00:00"), DateFormat.stringToMillis("2016-02-23 12:23:00")); + String condition; + + partitionDesc.setPartitionDateFormat("yyyy-MM-dd"); partitionDesc.setPartitionTimeFormat("H"); - TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 00:00:00"), - DateFormat.stringToMillis("2016-02-23 01:00:00")); - String condition =3D partitionConditionBuilder.buildDateRangeCondi= tion(partitionDesc, null, range); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals( + "((UNKNOWN_ALIAS.DATE_COLUMN =3D '2016-02-22' AND UNKNOWN_= ALIAS.HOUR_COLUMN >=3D '0') OR (UNKNOWN_ALIAS.DATE_COLUMN > '2016-02-22')) = AND ((UNKNOWN_ALIAS.DATE_COLUMN =3D '2016-02-23' AND UNKNOWN_ALIAS.HOUR_COL= UMN < '12') OR (UNKNOWN_ALIAS.DATE_COLUMN < '2016-02-23'))", + condition); + + partitionDesc.setPartitionDateFormat("yyyyMMdd"); + partitionDesc.setPartitionTimeFormat("HH:mm"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); Assert.assertEquals( - "((UNKNOWN_ALIAS.DATE_COLUMN =3D '2016-02-22' AND UNKNOWN_= ALIAS.HOUR_COLUMN >=3D '0') OR (UNKNOWN_ALIAS.DATE_COLUMN > '2016-02-22')) = AND ((UNKNOWN_ALIAS.DATE_COLUMN =3D '2016-02-23' AND UNKNOWN_ALIAS.HOUR_COL= UMN < '1') OR (UNKNOWN_ALIAS.DATE_COLUMN < '2016-02-23'))", + "((UNKNOWN_ALIAS.DATE_COLUMN =3D '20160222' AND UNKNOWN_AL= IAS.HOUR_COLUMN >=3D '00:00') OR (UNKNOWN_ALIAS.DATE_COLUMN > '20160222')) = AND ((UNKNOWN_ALIAS.DATE_COLUMN =3D '20160223' AND UNKNOWN_ALIAS.HOUR_COLUM= N < '12:23') OR (UNKNOWN_ALIAS.DATE_COLUMN < '20160223'))", condition); } =20 + @Test + public void testDateAndTimePartitionInt() { + PartitionDesc partitionDesc =3D new PartitionDesc(); + TblColRef col1 =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABL= E_NAME"), 1, "DATE_COLUMN", "integer"); + partitionDesc.setPartitionDateColumnRef(col1); + partitionDesc.setPartitionDateColumn(col1.getCanonicalName()); + TblColRef col2 =3D TblColRef.mockup(TableDesc.mockup("DEFAULT.TABL= E_NAME"), 2, "HOUR_COLUMN", "bigint"); + partitionDesc.setPartitionTimeColumnRef(col2); + partitionDesc.setPartitionTimeColumn(col2.getCanonicalName()); + TSRange range =3D new TSRange(DateFormat.stringToMillis("2016-02-2= 2 00:00:00"), DateFormat.stringToMillis("2016-02-23 12:23:00")); + String condition; + + partitionDesc.setPartitionDateFormat("yyyyMMdd"); + partitionDesc.setPartitionTimeFormat("HH"); + condition =3D partitionConditionBuilder.buildDateRangeCondition(pa= rtitionDesc, null, range); + Assert.assertEquals( + "((UNKNOWN_ALIAS.DATE_COLUMN =3D 20160222 AND UNKNOWN_ALIA= S.HOUR_COLUMN >=3D 00) OR (UNKNOWN_ALIAS.DATE_COLUMN > 20160222)) AND ((UNK= NOWN_ALIAS.DATE_COLUMN =3D 20160223 AND UNKNOWN_ALIAS.HOUR_COLUMN < 12) OR = (UNKNOWN_ALIAS.DATE_COLUMN < 20160223))", + condition); + + } } =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Partition time column may never be added > ---------------------------------------- > > Key: KYLIN-3665 > URL: https://issues.apache.org/jira/browse/KYLIN-3665 > Project: Kylin > Issue Type: Bug > Reporter: Chao Long > Assignee: Chao Long > Priority: Major > Fix For: v2.6.0 > > > The partition time column will never be added to the WHERE clause if the = partition date column is type of int or bigint and the date format is "yyyy= MMdd", "yyyyMMddHH", "yyyyMMddHHmm" or "yyyyMMddHHmmss". > Let=E2=80=99s say I have a fact table with two date partition column: day= as the format of integer (yyyyMMdd) and minute as the format of string (HH= mm). I have models created based on it and set the Partition Date Column to= be =E2=80=9Cday=E2=80=9D with the format of yyyyMMdd and the Partition Tim= e Column to be =E2=80=9Cminute=E2=80=9D with the format of HHmm. When I bui= ld the cube built on top of that model, I set the Start Date to be 2018-11-= 01 00:00:00 and the End Date to be 2018-11-01 01:00:00. The building proces= s is supposed to retrieve the data from the fact table in the range of =E2= =80=9Cday =3D 20181101 and minute>=3D=E2=80=990000=E2=80=99 and minute<=E2= =80=990100=E2=80=99=E2=80=9D. However, it retrieves the data in the range o= f =E2=80=9CWHERE 1=3D1 AND (DAY >=3D 20181101 AND DAY < 20181101), so no da= ta are actually retrieved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)