From issues-return-22125-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Wed Nov 28 08:58:48 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E3AD180658 for ; Wed, 28 Nov 2018 08:58:48 +0100 (CET) Received: (qmail 5200 invoked by uid 500); 28 Nov 2018 07:58:47 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 5191 invoked by uid 99); 28 Nov 2018 07:58:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2018 07:58:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A3524CE8AF for ; Wed, 28 Nov 2018 07:58:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XYhzlSdv71y4 for ; Wed, 28 Nov 2018 07:58:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EDFCE5F358 for ; Wed, 28 Nov 2018 07:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86740E00D4 for ; Wed, 28 Nov 2018 07:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1073C24DCE for ; Wed, 28 Nov 2018 07:34:00 +0000 (UTC) Date: Wed, 28 Nov 2018 07:34:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-2578) Refactor DistributedLock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-2578?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1670= 1484#comment-16701484 ]=20 ASF GitHub Bot commented on KYLIN-2578: --------------------------------------- coveralls commented on issue #365: KYLIN-2578, clean deprecated config("kyl= in.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442347902 =20 =20 ## Pull Request Test Coverage Report for [Build 3898](https://coveralls.= io/builds/20330244) =20 * **0** of **0** changed or added relevant lines in **0** files are co= vered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.001%**) to **25.949%** =20 --- =20 =20 | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/Rock= sDBLookupTable.java](https://coveralls.io/builds/20330244/source?filename= =3Dcore-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flook= up%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | =20 | Totals | [![Coverage Status](https://coveralls.io/builds/20330244/bad= ge)](https://coveralls.io/builds/20330244) | | :-- | --: | | Change from base [Build 3894](https://coveralls.io/builds/20327415): |= 0.001% | | Covered Lines: | 17651 | | Relevant Lines: | 68023 | =20 --- ##### =F0=9F=92=9B - [Coveralls](https://coveralls.io) =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Refactor DistributedLock > ------------------------ > > Key: KYLIN-2578 > URL: https://issues.apache.org/jira/browse/KYLIN-2578 > Project: Kylin > Issue Type: Improvement > Reporter: liyang > Assignee: liyang > Priority: Major > Fix For: v2.1.0 > > > The current {{DistributedLock}} could use some improvement: > - A {{lockClient}} is unnecessarily required. > - The {{watchPath}} is actually an on-unlock listener and the current nam= e failed to make it clear. > - Could add a blocking version of {{lockPath}} and that will ease use cas= es like KYLIN-2557 and {{GlobalDictionaryBuilder.lock()}} > - Should add more javadoc on the interface -- This message was sent by Atlassian JIRA (v7.6.3#76005)