kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3700) Quote sql identities when creating flat table
Date Wed, 28 Nov 2018 06:05:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701428#comment-16701428
] 

ASF GitHub Bot commented on KYLIN-3700:
---------------------------------------

coveralls commented on issue #362: KYLIN-3700 Quote sql identities when creating flat table
URL: https://github.com/apache/kylin/pull/362#issuecomment-442330731
 
 
   ## Pull Request Test Coverage Report for [Build 3896](https://coveralls.io/builds/20329464)
   
   * **72** of **244**   **(29.51%)**  changed or added relevant lines in **15** files are
covered.
   * **6** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.006%**) to **25.941%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableRef.java](https://coveralls.io/builds/20329464/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableRef.java#L72)
| 0 | 1 | 0.0%
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/JdbcConnector.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2FJdbcConnector.java#L89)
| 2 | 3 | 66.67%
   | [source-hive/src/main/java/org/apache/kylin/source/hive/GarbageCollectionStep.java](https://coveralls.io/builds/20329464/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FGarbageCollectionStep.java#L67)
| 0 | 1 | 0.0%
   | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/20329464/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L121)
| 4 | 5 | 80.0%
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/SqlConverter.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FSqlConverter.java#L75)
| 7 | 9 | 77.78%
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfiguer.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfiguer.java#L132)
| 6 | 9 | 66.67%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/20329464/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L223)
| 0 | 6 | 0.0%
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FConvSqlWriter.java#L156)
| 5 | 12 | 41.67%
   | [source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcHiveMRInput.java](https://coveralls.io/builds/20329464/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2FJdbcHiveMRInput.java#L160)
| 3 | 11 | 27.27%
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FAbstractJdbcAdaptor.java#L300)
| 4 | 18 | 22.22%
   <!-- | **Total:** | **72** | **244** | **29.51%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20329464/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
| 1 | 78.12% |
   | [core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java](https://coveralls.io/builds/20329464/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFlatTable.java#L235)
| 2 | 0.0% |
   | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FDefaultAdaptor.java#L145)
| 3 | 35.51% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/20329464/badge)](https://coveralls.io/builds/20329464)
|
   | :-- | --: |
   | Change from base [Build 3894](https://coveralls.io/builds/20327415): |  -0.006% |
   | Covered Lines: | 17690 |
   | Relevant Lines: | 68193 |
   
   ---
   ##### đź’›  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Quote sql identities when creating flat table
> ---------------------------------------------
>
>                 Key: KYLIN-3700
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3700
>             Project: Kylin
>          Issue Type: Improvement
>          Components: RDBMS Source
>    Affects Versions: v2.5.1
>            Reporter: XiaoXiang Yu
>            Assignee: XiaoXiang Yu
>            Priority: Major
>             Fix For: v2.6.0
>
>
> *When kyin operate with different data source, DDL/DML may be broken because datasource
has some different specific reserved keyword.* 
>  
> Sql identity should be quoted when:
> 1) Create flat table.
> 2) Push down to different datasource (different RDBMS has different reserved keyword)
.
>  
> {code:java}
> 2018-10-05 03:05:04,143 ERROR [pool-25-thread-2] conv.SqlConverter : Failed to default
convert sql, will use the input: SELECT COUNT(TIME_KEY), TIME_KEY FROM CUBE.OPERATIONS_TIME
WHERE TIME_KEY IS NOT NULL GROUP BY TIME_KEY ORDER BY COUNT(TIME_KEY) DESC LIMIT 10
> org.apache.calcite.sql.parser.SqlParseException: Encountered "FROM CUBE" at line 1, column
34.
> Was expecting one of:
>  <EOF> 
>  "ORDER" ...
>  "LIMIT" ...
>  "OFFSET" ...
>  "FETCH" ...
>  "FROM" <IDENTIFIER> ...
>  "FROM" <QUOTED_IDENTIFIER> ...
>  "FROM" <BACK_QUOTED_IDENTIFIER> ...
>  "FROM" <BRACKET_QUOTED_IDENTIFIER> ...
>  "FROM" <UNICODE_QUOTED_IDENTIFIER> ...
>  "FROM" "LATERAL" ...
>  "FROM" "(" ...
>  "FROM" "UNNEST" ...
>  "FROM" "TABLE" ...
>  "," ...
>  "AS" ...
>  <IDENTIFIER> ...
>  <QUOTED_IDENTIFIER> ...
>  <BACK_QUOTED_IDENTIFIER> ...
>  <BRACKET_QUOTED_IDENTIFIER> ...
>  <UNICODE_QUOTED_IDENTIFIER> ...
>  "." ...
>  "INTERSECT" ...
>  "EXCEPT" ...
>  "MINUS" ...
>  "(" ...
>  
>  at org.apache.calcite.sql.parser.impl.SqlParserImpl.convertException(SqlParserImpl.java:349)
>  at org.apache.calcite.sql.parser.impl.SqlParserImpl.normalizeException(SqlParserImpl.java:130){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message