kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3669) Add log to GTStreamAggregateScanner
Date Wed, 21 Nov 2018 04:17:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694205#comment-16694205
] 

ASF subversion and git services commented on KYLIN-3669:
--------------------------------------------------------

Commit 78a5f349e8f744edeed8072b0dc82ce7d21e052f in kylin's branch refs/heads/master from [~Aron.tao]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=78a5f34 ]

KYLIN-3669, add log to indicate the case when using GTStreamAggregateScanner.


> Add log to GTStreamAggregateScanner
> -----------------------------------
>
>                 Key: KYLIN-3669
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3669
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Trivial
>
> There's no log printing in GTStreamAggregateScanner, and you know nothing about whether
you go to this path or not, it's pretty unfriendly for trouble shooting.
> Code in _SegmentCubeTupleIterator_.
> {code:java}
> boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator;
> if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
>     ...
>     // input records are ordered, leverage stream aggregator to produce possibly fewer
records
>     try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner,
scanRequest)) {
>         result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
>     } catch (IOException ioe) {
>         // implementation of close method of anonymous IGTScanner is empty, no way throw
exception
>         throw new IllegalStateException("IOException is not expected here.", ioe);
>     }
>     return result;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message