kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
Date Mon, 05 Nov 2018 06:44:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674737#comment-16674737
] 

ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------

codecov-io edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar:
Make sure this ex…
URL: https://github.com/apache/kylin/pull/326#issuecomment-435556421
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=h1) Report
   > Merging [#326](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/caf109ea016c0bcbbef8f15c26b620003f253955?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/326/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #326      +/-   ##
   ============================================
   - Coverage     21.55%   21.54%   -0.02%     
   + Complexity     4579     4577       -2     
   ============================================
     Files          1112     1112              
     Lines         71186    71186              
     Branches      10284    10285       +1     
   ============================================
   - Hits          15343    15334       -9     
   - Misses        54373    54379       +6     
   - Partials       1470     1473       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/net/spy/memcached/RefinedKetamaNodeLocator.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9uZXQvc3B5L21lbWNhY2hlZC9SZWZpbmVkS2V0YW1hTm9kZUxvY2F0b3IuamF2YQ==)
| `24.17% <0%> (ø)` | `8 <0> (ø)` | :arrow_down: |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.3% <0%> (-1.83%)` | `7% <0%> (ø)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=footer).
Last update [caf109e...80027df](https://codecov.io/gh/apache/kylin/pull/326?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix sonar reported static code issues
> -------------------------------------
>
>                 Key: KYLIN-3597
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3597
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>            Reporter: Shaofeng SHI
>            Priority: Major
>             Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message