kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] shaofengshi closed pull request #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.
Date Wed, 28 Nov 2018 11:19:36 GMT
shaofengshi closed pull request #365: minor, remove a deprecated configuration("kylin.job.lock")
usage in the code.
URL: https://github.com/apache/kylin/pull/365
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
index a9988734f8..c33b21b315 100644
--- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
+++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
@@ -58,8 +58,7 @@
  *
  * to enable the distributed job server, you need to set and update three configs in the
kylin.properties:
  *  1. kylin.job.scheduler.default=2
- *  2. kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperJobLock
- *  3. add all the job servers and query servers to the kylin.server.cluster-servers
+ *  2. add all the job servers and query servers to the kylin.server.cluster-servers
  */
 public class DistributedScheduler implements Scheduler<AbstractExecutable>, ConnectionStateListener
{
     private static final Logger logger = LoggerFactory.getLogger(DistributedScheduler.class);
diff --git a/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
b/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
index be54dce735..cc5add08d9 100644
--- a/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
+++ b/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
@@ -69,7 +69,6 @@
     @BeforeClass
     public static void setup() throws Exception {
         staticCreateTestMetadata();
-        System.setProperty("kylin.job.lock", "org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock");
 
         new File(confDstPath1).getParentFile().mkdirs();
         new File(confDstPath2).getParentFile().mkdirs();
@@ -128,7 +127,6 @@ public static void after() throws Exception {
         }
 
         FileUtils.deleteDirectory(localMetaDir);
-        System.clearProperty("kylin.job.lock");
         System.clearProperty("kylin.metadata.url");
         staticCleanupTestMetadata();
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message