From issues-return-21212-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Fri Oct 26 15:39:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69B1B180675 for ; Fri, 26 Oct 2018 15:39:05 +0200 (CEST) Received: (qmail 61452 invoked by uid 500); 26 Oct 2018 13:39:04 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 61443 invoked by uid 99); 26 Oct 2018 13:39:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 13:39:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F2396C222E for ; Fri, 26 Oct 2018 13:39:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Z4oHSAePToUO for ; Fri, 26 Oct 2018 13:39:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 31D1A5F217 for ; Fri, 26 Oct 2018 13:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 58E1BE00EA for ; Fri, 26 Oct 2018 13:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2551F23F98 for ; Fri, 26 Oct 2018 13:39:00 +0000 (UTC) Date: Fri, 26 Oct 2018 13:39:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3648) Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3648?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1666= 5180#comment-16665180 ]=20 ASF GitHub Bot commented on KYLIN-3648: --------------------------------------- shaofengshi closed pull request #315: KYLIN-3648 Use Path as the input of a= ddResource URL: https://github.com/apache/kylin/pull/315 =20 =20 =20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBa= seConnection.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hb= ase/HBaseConnection.java index 53e8a686f7..bbe9d2ea93 100644 --- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConne= ction.java +++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConne= ction.java @@ -207,7 +207,7 @@ public static void addHBaseClusterNNHAConfiguration(Con= figuration conf) { return; } Configuration hdfsConf =3D new Configuration(false); - hdfsConf.addResource(hdfsConfigFile); + hdfsConf.addResource(new Path(hdfsConfigFile)); Collection nameServices =3D hdfsConf.getTrimmedStringColle= ction(DFSConfigKeys.DFS_NAMESERVICES); Collection mainNameServices =3D conf.getTrimmedStringColle= ction(DFSConfigKeys.DFS_NAMESERVICES); for (String serviceId : nameServices) { =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to confi= guration properly > -------------------------------------------------------------------------= ----------------- > > Key: KYLIN-3648 > URL: https://issues.apache.org/jira/browse/KYLIN-3648 > Project: Kylin > Issue Type: Bug > Components: Storage - HBase > Reporter: Shaofeng SHI > Priority: Minor > Fix For: v2.6.0 > > > From=C2=A0this blog,=C2=A0 we know that Configuration.addResource should = better use a Path as the input instead of a string: > conf.addResource(new Path("/home/hadoop/conf/core-site.xml")); > [https://dzone.com/articles/debugging-%E2%80%9Cwrong-fs-expected] > =C2=A0 > But in Kylin's HBaseConnection, it add the hbase cluster fs configure fil= e as string: > {code:java} > String hdfsConfigFile =3D KylinConfig.getInstanceFromEnv().getHBaseCluste= rHDFSConfigFile(); > if (hdfsConfigFile =3D=3D null || hdfsConfigFile.isEmpty()) { > return; > } > Configuration hdfsConf =3D new Configuration(false); > hdfsConf.addResource(hdfsConfigFile); > {code} > This may make it doesn't work. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)