From issues-return-20809-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Wed Oct 17 08:09:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A4AC18061A for ; Wed, 17 Oct 2018 08:09:08 +0200 (CEST) Received: (qmail 23402 invoked by uid 500); 17 Oct 2018 06:09:08 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 23388 invoked by uid 99); 17 Oct 2018 06:09:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2018 06:09:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 55F7B182338 for ; Wed, 17 Oct 2018 06:09:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id RrGvs_8xZmty for ; Wed, 17 Oct 2018 06:09:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 885475FD47 for ; Wed, 17 Oct 2018 06:09:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9C7FFE00E1 for ; Wed, 17 Oct 2018 06:09:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0926824E6B for ; Wed, 17 Oct 2018 06:09:04 +0000 (UTC) Date: Wed, 17 Oct 2018 06:09:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3632) Add configuration that can switch on/off preparedStatement cache in Kylin server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3632?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1665= 3006#comment-16653006 ]=20 ASF GitHub Bot commented on KYLIN-3632: --------------------------------------- codecov-io edited a comment on issue #290: KYLIN-3632 Add configuration tha= t can switch on/off preparedStatement cache URL: https://github.com/apache/kylin/pull/290#issuecomment-429717664 =20 =20 # [Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=3Dpr&el=3Dh1= ) Report > Merging [#290](https://codecov.io/gh/apache/kylin/pull/290?src=3Dpr&el= =3Ddesc) into [master](https://codecov.io/gh/apache/kylin/commit/5f6007ff2b= 5aead4781c876fa3203dd67188d90b?src=3Dpr&el=3Ddesc) will **decrease** covera= ge by `<.01%`. > The diff coverage is `0%`. =20 [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/290= /graphs/tree.svg?width=3D650&token=3DJawVgbgsVo&height=3D150&src=3Dpr)](htt= ps://codecov.io/gh/apache/kylin/pull/290?src=3Dpr&el=3Dtree) =20 ```diff @@ Coverage Diff @@ ## master #290 +/- ## =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - Coverage 21.3% 21.3% -0.01% =20 Complexity 4444 4444 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Files 1087 1087 =20 Lines 69983 69984 +1 =20 Branches 10109 10109 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Hits 14907 14907 =20 - Misses 53672 53675 +3 =20 + Partials 1404 1402 -2 ``` =20 =20 | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/290?src=3Dpr&= el=3Dtree) | Coverage =CE=94 | Complexity =CE=94 | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codeco= v.io/gh/apache/kylin/pull/290/diff?src=3Dpr&el=3Dtree#diff-c2VydmVyLWJhc2Uv= c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2U= uamF2YQ=3D=3D) | `0% <0%> (=C3=B8)` | `0 <0> (=C3=B8)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codeco= v.io/gh/apache/kylin/pull/290/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1jb21tb24v= c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF= 2YQ=3D=3D) | `14.66% <0%> (-0.03%)` | `36 <0> (=C3=B8)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codeco= v.io/gh/apache/kylin/pull/290/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1jdWJlL3Ny= Yy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9= yZS5qYXZh) | `70.21% <0%> (-0.61%)` | `7% <0%> (=C3=B8)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codeco= v.io/gh/apache/kylin/pull/290/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1tZXRhZGF0= YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2V= uZXJhdG9yLmphdmE=3D) | `72.29% <0%> (+1.35%)` | `8% <0%> (=C3=B8)` | :arrow= _down: | =20 ------ =20 [Continue to review full report at Codecov](https://codecov.io/gh/apache= /kylin/pull/290?src=3Dpr&el=3Dcontinue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/c= odecov-delta) > `=CE=94 =3D absolute (impact)`, `=C3=B8 =3D not affected`, = `? =3D missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/290?src= =3Dpr&el=3Dfooter). Last update [5f6007f...41e3300](https://codecov.io/gh/a= pache/kylin/pull/290?src=3Dpr&el=3Dlastupdated). Read the [comment docs](ht= tps://docs.codecov.io/docs/pull-request-comments). =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Add configuration that can switch on/off preparedStatement cache in Kylin= server > -------------------------------------------------------------------------= ------- > > Key: KYLIN-3632 > URL: https://issues.apache.org/jira/browse/KYLIN-3632 > Project: Kylin > Issue Type: Improvement > Components: Query Engine > Reporter: Ma Gang > Assignee: Ma Gang > Priority: Minor > Fix For: v2.5.1 > > > From=C2=A0Kylin 2.5 we introduce preparedStatement cache feature, it can = be turn on/off for each request by adding a new field "enableStatementCache= " in the query request, by default it is on. We need to add a switch in ser= ver level, the preparedStatement cache can take effective only when the swi= tch is on, by default, it will be set to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)