From issues-return-20721-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Sun Oct 14 13:05:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6BF66180670 for ; Sun, 14 Oct 2018 13:05:03 +0200 (CEST) Received: (qmail 88082 invoked by uid 500); 14 Oct 2018 11:05:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 88073 invoked by uid 99); 14 Oct 2018 11:05:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Oct 2018 11:05:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 303CC180AB2 for ; Sun, 14 Oct 2018 11:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GPmzZa7i7A7o for ; Sun, 14 Oct 2018 11:05:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 146BD5F382 for ; Sun, 14 Oct 2018 11:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8CB50E0177 for ; Sun, 14 Oct 2018 11:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1778F210A0 for ; Sun, 14 Oct 2018 11:05:00 +0000 (UTC) Date: Sun, 14 Oct 2018 11:05:00 +0000 (UTC) From: "jiatao.tao (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KYLIN-3630) remove unused fields in the implementations of MeasureType MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiatao.tao updated KYLIN-3630: ------------------------------ Description: Like in code org.apache.kylin.measure.raw.RawMeasureType#RawMeasureType, we can see that both funcName and dataType are use, and this can be remove cuz there's no constraint on its constructor. And after we done that, we can mo easily test MeasureType without passing in meaningless args. !screenshot-1.png! Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType !image-2018-10-14-18-56-29-010.png! was: !image-2018-10-14-18-56-29-010.png! > remove unused fields in the implementations of MeasureType > ---------------------------------------------------------- > > Key: KYLIN-3630 > URL: https://issues.apache.org/jira/browse/KYLIN-3630 > Project: Kylin > Issue Type: Improvement > Reporter: jiatao.tao > Assignee: jiatao.tao > Priority: Minor > Attachments: image-2018-10-14-18-56-29-010.png, screenshot-1.png > > > Like in code org.apache.kylin.measure.raw.RawMeasureType#RawMeasureType, we can see that both funcName and dataType are use, and this can be remove cuz there's no constraint on its constructor. > And after we done that, we can mo easily test MeasureType without passing in meaningless args. > !screenshot-1.png! > Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType > !image-2018-10-14-18-56-29-010.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)