kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3648) Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly
Date Fri, 26 Oct 2018 13:39:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665180#comment-16665180
] 

ASF GitHub Bot commented on KYLIN-3648:
---------------------------------------

shaofengshi closed pull request #315: KYLIN-3648 Use Path as the input of addResource
URL: https://github.com/apache/kylin/pull/315
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java
index 53e8a686f7..bbe9d2ea93 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java
@@ -207,7 +207,7 @@ public static void addHBaseClusterNNHAConfiguration(Configuration conf)
{
             return;
         }
         Configuration hdfsConf = new Configuration(false);
-        hdfsConf.addResource(hdfsConfigFile);
+        hdfsConf.addResource(new Path(hdfsConfigFile));
         Collection<String> nameServices = hdfsConf.getTrimmedStringCollection(DFSConfigKeys.DFS_NAMESERVICES);
         Collection<String> mainNameServices = conf.getTrimmedStringCollection(DFSConfigKeys.DFS_NAMESERVICES);
         for (String serviceId : nameServices) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly
> ------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3648
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3648
>             Project: Kylin
>          Issue Type: Bug
>          Components: Storage - HBase
>            Reporter: Shaofeng SHI
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> From this blog,  we know that Configuration.addResource should better use a Path as
the input instead of a string:
> conf.addResource(new Path("/home/hadoop/conf/core-site.xml"));
> [https://dzone.com/articles/debugging-%E2%80%9Cwrong-fs-expected]
>  
> But in Kylin's HBaseConnection, it add the hbase cluster fs configure file as string:
> {code:java}
> String hdfsConfigFile = KylinConfig.getInstanceFromEnv().getHBaseClusterHDFSConfigFile();
> if (hdfsConfigFile == null || hdfsConfigFile.isEmpty()) {
>     return;
> }
> Configuration hdfsConf = new Configuration(false);
> hdfsConf.addResource(hdfsConfigFile);
> {code}
> This may make it doesn't work.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message