kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3648) Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly
Date Thu, 25 Oct 2018 08:03:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663409#comment-16663409
] 

ASF GitHub Bot commented on KYLIN-3648:
---------------------------------------

codecov-io commented on issue #315: KYLIN-3648 Use Path as the input of addResource
URL: https://github.com/apache/kylin/pull/315#issuecomment-432953367
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=h1) Report
   > Merging [#315](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/e9e427a73ef08314f983a2f3dfb37ecb37c752be?src=pr&el=desc)
will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/315/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #315   +/-   ##
   =========================================
     Coverage     21.29%   21.29%           
   + Complexity     4446     4445    -1     
   =========================================
     Files          1090     1090           
     Lines         70016    70016           
     Branches      10098    10098           
   =========================================
     Hits          14913    14913           
   + Misses        53702    53701    -1     
   - Partials       1401     1402    +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/315/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/315/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/315/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/315/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=footer).
Last update [e9e427a...3bcef1a](https://codecov.io/gh/apache/kylin/pull/315?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kylin may not add "kylin.storage.hbase.cluster-hdfs-config-file" to configuration properly
> ------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3648
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3648
>             Project: Kylin
>          Issue Type: Bug
>          Components: Storage - HBase
>            Reporter: Shaofeng SHI
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> From this blog,  we know that Configuration.addResource should better use a Path as
the input instead of a string:
> conf.addResource(new Path("/home/hadoop/conf/core-site.xml"));
> [https://dzone.com/articles/debugging-%E2%80%9Cwrong-fs-expected]
>  
> But in Kylin's HBaseConnection, it add the hbase cluster fs configure file as string:
> {code:java}
> String hdfsConfigFile = KylinConfig.getInstanceFromEnv().getHBaseClusterHDFSConfigFile();
> if (hdfsConfigFile == null || hdfsConfigFile.isEmpty()) {
>     return;
> }
> Configuration hdfsConf = new Configuration(false);
> hdfsConf.addResource(hdfsConfigFile);
> {code}
> This may make it doesn't work.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message