kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3635) Percentile calculation on Spark engine is wrong
Date Mon, 29 Oct 2018 03:24:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666696#comment-16666696
] 

ASF GitHub Bot commented on KYLIN-3635:
---------------------------------------

shaofengshi commented on a change in pull request #316: KYLIN-3635, make a stronger constraint
about implementing method reset().
URL: https://github.com/apache/kylin/pull/316#discussion_r228788317
 
 

 ##########
 File path: core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
 ##########
 @@ -43,9 +43,7 @@
 
     abstract public V valueOf(String[] values, MeasureDesc measureDesc, Map<TblColRef,
Dictionary<String>> dictionaryMap);
 
-    public void reset() {
-
-    }
+    abstract public void reset();
 
 Review comment:
   Jiatao, it is good to make this method as abstract; If you can add some comment on this
method to tell the developer why this method is so important, that would be great.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Percentile calculation on Spark engine is wrong
> -----------------------------------------------
>
>                 Key: KYLIN-3635
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3635
>             Project: Kylin
>          Issue Type: Bug
>          Components: Spark Engine
>    Affects Versions: v2.3.0, v2.3.1, v2.4.0, v2.3.2, v2.4.1, v2.5.0
>            Reporter: Shaofeng SHI
>            Assignee: Shaofeng SHI
>            Priority: Major
>             Fix For: v2.4.2, v2.5.1
>
>
> As titled; Received reporting that percentile result is wrong when using Spark engine.
Checked the code and found the object was reused and not reset, the problem won't happen
on normal MR as it would be serialized before next call, but would be a problem on Spark,
as the object was cached in-memory and be serialized later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message