kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3632) Add configuration that can switch on/off preparedStatement cache in Kylin server
Date Mon, 15 Oct 2018 05:59:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649757#comment-16649757
] 

ASF GitHub Bot commented on KYLIN-3632:
---------------------------------------

codecov-io commented on issue #290: KYLIN-3632 Add configuration that can switch on/off preparedStatement
cache
URL: https://github.com/apache/kylin/pull/290#issuecomment-429717664
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=h1) Report
   > Merging [#290](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/5f6007ff2b5aead4781c876fa3203dd67188d90b?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/290/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #290      +/-   ##
   ============================================
   - Coverage     21.29%   21.29%   -0.01%     
   + Complexity     4444     4442       -2     
   ============================================
     Files          1087     1087              
     Lines         69983    69984       +1     
     Branches      10109    10109              
   ============================================
   - Hits          14903    14902       -1     
   - Misses        53676    53677       +1     
   - Partials       1404     1405       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.66% <0%> (-0.03%)` | `36 <0> (ø)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=footer).
Last update [5f6007f...3fcb1d5](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add configuration that can switch on/off preparedStatement cache in Kylin server
> --------------------------------------------------------------------------------
>
>                 Key: KYLIN-3632
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3632
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Ma Gang
>            Assignee: Ma Gang
>            Priority: Minor
>             Fix For: v2.5.1
>
>
> From Kylin 2.5 we introduce preparedStatement cache feature, it can be turn on/off for
each request by adding a new field "enableStatementCache" in the query request, by default
it is on. We need to add a switch in server level, the preparedStatement cache can take effective
only when the switch is on, by default, it will be set to false.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message