kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3630) remove unused fields in the implementations of MeasureType
Date Sun, 14 Oct 2018 11:14:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649344#comment-16649344
] 

ASF GitHub Bot commented on KYLIN-3630:
---------------------------------------

tttMelody opened a new pull request #289: KYLIN-3630, remove unused fields in the implementations
of MeasureType
URL: https://github.com/apache/kylin/pull/289
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> remove unused fields in the implementations of MeasureType
> ----------------------------------------------------------
>
>                 Key: KYLIN-3630
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3630
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: jiatao.tao
>            Assignee: jiatao.tao
>            Priority: Minor
>
> In code RawMeasureType#RawMeasureType, we can see that both funcName and  dataType are
use, and this can be remove cuz there's no constraint on its constructor.
> {code:java}
>     @SuppressWarnings("unused")
>     private final DataType dataType;
>     public RawMeasureType(String funcName, DataType dataType) {
>         this.dataType = dataType;
>     }
> {code}
> And after we done that, we can more easily test MeasureType without passing in meaningless
args.
> Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType, other implementations
can be cleaner.
> {code:java}
>         @Override
>         public MeasureType<Object> createMeasureType(String funcName, DataType
dataType) {
>             return new DimCountDistinctMeasureType();
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message