kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiatao.tao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KYLIN-3630) remove unused fields in the implementations of MeasureType
Date Sun, 14 Oct 2018 11:06:00 GMT

     [ https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

jiatao.tao updated KYLIN-3630:
------------------------------
    Attachment:     (was: image-2018-10-14-18-56-29-010.png)

> remove unused fields in the implementations of MeasureType
> ----------------------------------------------------------
>
>                 Key: KYLIN-3630
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3630
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: jiatao.tao
>            Assignee: jiatao.tao
>            Priority: Minor
>
> Like in code org.apache.kylin.measure.raw.RawMeasureType#RawMeasureType, we can see that
both funcName and  dataType are use, and this can be remove cuz there's no constraint on its
constructor.
> And after we done that, we can mo easily test MeasureType without passing in meaningless
args.
> Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message