kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
Date Mon, 08 Oct 2018 14:05:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641875#comment-16641875
] 

ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------

codecov-io commented on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427846885
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@09c5668`). [Click
here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `15.62%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/283/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #283   +/-   ##
   =========================================
     Coverage          ?   21.29%           
     Complexity        ?     4437           
   =========================================
     Files             ?     1087           
     Lines             ?    69976           
     Branches          ?    10125           
   =========================================
     Hits              ?    14898           
     Misses            ?    53677           
     Partials          ?     1401
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/kylin/storage/gtrecord/CubeSegmentScanner.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVTZWdtZW50U2Nhbm5lci5qYXZh)
| `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...n/storage/hbase/util/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1pvb2tlZXBlckRpc3RyaWJ1dGVkTG9jay5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...va/org/apache/kylin/dict/AppendTrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0FwcGVuZFRyaWVEaWN0aW9uYXJ5LmphdmE=)
| `57.5% <0%> (ø)` | `13 <0> (?)` | |
   | [...n/java/org/apache/kylin/common/util/CheckUtil.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NoZWNrVXRpbC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../apache/kylin/common/persistence/BrokenEntity.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Ccm9rZW5FbnRpdHkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `77.77% <33.33%> (ø)` | `6 <0> (?)` | |
   | [...he/kylin/common/persistence/HDFSResourceStore.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh)
| `22.33% <40%> (ø)` | `5 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=footer).
Last update [09c5668...5e9ef99](https://codecov.io/gh/apache/kylin/pull/283?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix sonar reported static code issues
> -------------------------------------
>
>                 Key: KYLIN-3597
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3597
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>            Reporter: Shaofeng SHI
>            Priority: Major
>             Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message