kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3594) Select with Catalog fails
Date Sat, 06 Oct 2018 14:26:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640737#comment-16640737
] 

ASF GitHub Bot commented on KYLIN-3594:
---------------------------------------

codecov-io edited a comment on issue #268: KYLIN-3594 Obey JDBC standard
URL: https://github.com/apache/kylin/pull/268#issuecomment-425625134
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@f859e43`). [Click
here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `12.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/268/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #268   +/-   ##
   =========================================
     Coverage          ?   21.29%           
     Complexity        ?     4436           
   =========================================
     Files             ?     1087           
     Lines             ?    69983           
     Branches          ?    10126           
   =========================================
     Hits              ?    14900           
     Misses            ?    53682           
     Partials          ?     1401
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=)
| `58.44% <22.22%> (ø)` | `19 <1> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=footer).
Last update [f859e43...25ed4a5](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Select with Catalog fails
> -------------------------
>
>                 Key: KYLIN-3594
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3594
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Hosur Narahari
>            Assignee: XiaoXiang Yu
>            Priority: Major
>
> By using DatabaseMetaData if we get catalog using getCatalogs() method, it return value
"defaultCatalog". It returns actual hive schema when we execute getSchemas().
> According to JDBC contract, catalog.schema.table should be valid from clause and many
query layers use that. But kylin fails when we execute that query.
> I've tried to write sample code piece for that below.
>  
>         _DatabaseMetaData db = conn.getMetaData();_
>         _ResultSet catalogSet = db.getCatalogs();_
>         _String catalog = "";_
>         _if(catalogSet.next()) {_
>             _catalog = catalogSet.getString("TABLE_CAT");_
>         _}_
>         _ResultSet schemaSet = db.getSchemas();_
>         _String schema = "";_
>         _if(schemaSet.next()) {_
>             _schema = schemaSet.getString("TABLE_SCHEM");_
>         _}_
>         _StringBuilder sb = new StringBuilder("SELECT * FROM ");_
>         _if(!catalog.isEmpty()) {_
>             _sb.append(catalog + ".");_
>         _}_
>         _if(!schema.isEmpty()) {_
>             _sb.append(schema + ".");_
>         _}_
>         _sb.append("kylin_sales limit 10");_
>         _String query = sb.toString();_
>         _Statement stat = conn.createStatement();_
>         _ResultSet rs = stat.executeQuery(query);_
>         _while(rs.next()) {_
>             _System.out.println(rs.getObject("trans_id"));_
>         _}_
> In short, the above snippet is executing the query,
> _select * from defaultCatalog.DEFAULT.kylin_sales._
>  
> Same thing happens even with different schemas if we have like,
> _select * from defaultCatalog.test.kylin_sales_ also fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message