kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lijun Cao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3586) Boxing/unboxing to parse a primitive is suboptimal
Date Sun, 07 Oct 2018 13:47:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641066#comment-16641066
] 

Lijun Cao commented on KYLIN-3586:
----------------------------------

Thanks, Ted Yu. I also modify parseInt to valueOf in KylinClient#wrapObject beacause its return
type is Object.

> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
>                 Key: KYLIN-3586
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3586
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Lijun Cao
>            Priority: Major
>             Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
>             int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to valIdx.
> Integer.parseInt() should be used instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message