kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3556) Interned string should not be used as lock object
Date Mon, 29 Oct 2018 09:43:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666919#comment-16666919
] 

ASF GitHub Bot commented on KYLIN-3556:
---------------------------------------

etherge opened a new pull request #319: KYLIN-3556, replace String.intern to avoid unexpected
locking collisions
URL: https://github.com/apache/kylin/pull/319
 
 
   Locking on an interned string can cause unexpected locking collisions with other part of
code. A better option is **_Interner_** in guava.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Interned string should not be used as lock object
> -------------------------------------------------
>
>                 Key: KYLIN-3556
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3556
>             Project: Kylin
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: v2.5.0
>            Reporter: Ted Yu
>            Assignee:  Kaige Liu
>            Priority: Minor
>             Fix For: v2.5.1
>
>
> In JDBCResourceDAO :
> {code}
>             public void execute(Connection connection) throws SQLException {
>                 synchronized (resPath.intern()) {
> {code}
> Locking on an interned string can cause unexpected locking collisions with other part
of code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message