From issues-return-20201-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Sep 25 03:24:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5A33180649 for ; Tue, 25 Sep 2018 03:24:02 +0200 (CEST) Received: (qmail 26796 invoked by uid 500); 25 Sep 2018 01:24:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 26786 invoked by uid 99); 25 Sep 2018 01:24:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2018 01:24:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 91A681A0FC8 for ; Tue, 25 Sep 2018 01:24:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zAQ-dcyQdTmd for ; Tue, 25 Sep 2018 01:24:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C45D55F41C for ; Tue, 25 Sep 2018 01:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 51C0FE0047 for ; Tue, 25 Sep 2018 01:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 10BA823F9C for ; Tue, 25 Sep 2018 01:24:00 +0000 (UTC) Date: Tue, 25 Sep 2018 01:24:00 +0000 (UTC) From: "Yichen Zhou (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3589) Different type is used to check presence in Collection in AclPermissionUtil MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626656#comment-16626656 ] Yichen Zhou commented on KYLIN-3589: ------------------------------------ I will fix this. > Different type is used to check presence in Collection in AclPermissionUtil > --------------------------------------------------------------------------- > > Key: KYLIN-3589 > URL: https://issues.apache.org/jira/browse/KYLIN-3589 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Assignee: Yichen Zhou > Priority: Major > > Here is related code: > {code} > public static List transformAuthorities(Collection authorities) { > List ret = new ArrayList(); > for (GrantedAuthority auth : authorities) { > if (!authorities.contains(auth.getAuthority())) { > {code} > auth.getAuthority() shouldn't be used to check presence in the Collection since it is not of GrantedAuthority type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)