From issues-return-20407-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Thu Sep 27 17:19:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 58D35180652 for ; Thu, 27 Sep 2018 17:19:04 +0200 (CEST) Received: (qmail 31111 invoked by uid 500); 27 Sep 2018 15:19:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 31102 invoked by uid 99); 27 Sep 2018 15:19:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2018 15:19:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0742C180363 for ; Thu, 27 Sep 2018 15:19:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PcEokCk50K2N for ; Thu, 27 Sep 2018 15:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C50155F230 for ; Thu, 27 Sep 2018 15:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 59078E1013 for ; Thu, 27 Sep 2018 15:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1855A23F9C for ; Thu, 27 Sep 2018 15:19:00 +0000 (UTC) Date: Thu, 27 Sep 2018 15:19:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3588?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1663= 0603#comment-16630603 ]=20 ASF GitHub Bot commented on KYLIN-3588: --------------------------------------- codecov-io edited a comment on issue #248: KYLIN-3588, fix potentially dupl= icate putting in RemoveBlackoutRealiz=E2=80=A6 URL: https://github.com/apache/kylin/pull/248#issuecomment-424234716 =20 =20 # [Codecov](https://codecov.io/gh/apache/kylin/pull/248?src=3Dpr&el=3Dh1= ) Report > :exclamation: No coverage uploaded for pull request base (`master@9ae0= 3f6`). [Click here to learn what that means](https://docs.codecov.io/docs/e= rror-reference#section-missing-base-commit). > The diff coverage is `0%`. =20 [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/248= /graphs/tree.svg?width=3D650&token=3DJawVgbgsVo&height=3D150&src=3Dpr)](htt= ps://codecov.io/gh/apache/kylin/pull/248?src=3Dpr&el=3Dtree) =20 ```diff @@ Coverage Diff @@ ## master #248 +/- ## =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Coverage ? 21.15% =20 Complexity ? 4405 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Files ? 1086 =20 Lines ? 69745 =20 Branches ? 10088 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Hits ? 14758 =20 Misses ? 53588 =20 Partials ? 1399 ``` =20 =20 | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/248?src=3Dpr&= el=3Dtree) | Coverage =CE=94 | Complexity =CE=94 | | |---|---|---|---| | [.../routing/rules/RemoveBlackoutRealizationsRule.java](https://codeco= v.io/gh/apache/kylin/pull/248/diff?src=3Dpr&el=3Dtree#diff-cXVlcnkvc3JjL21h= aW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JvdXRpbmcvcnVsZXMvUmVtb3ZlQmxhY2t= vdXRSZWFsaXphdGlvbnNSdWxlLmphdmE=3D) | `0% <0%> (=C3=B8)` | `0 <0> (?)` | | =20 ------ =20 [Continue to review full report at Codecov](https://codecov.io/gh/apache= /kylin/pull/248?src=3Dpr&el=3Dcontinue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/c= odecov-delta) > `=CE=94 =3D absolute (impact)`, `=C3=B8 =3D not affected`, = `? =3D missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/248?src= =3Dpr&el=3Dfooter). Last update [9ae03f6...46861d4](https://codecov.io/gh/a= pache/kylin/pull/248?src=3Dpr&el=3Dlastupdated). Read the [comment docs](ht= tps://docs.codecov.io/docs/pull-request-comments). =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map > ----------------------------------------------------------------------- > > Key: KYLIN-3588 > URL: https://issues.apache.org/jira/browse/KYLIN-3588 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Assignee: jiatao.tao > Priority: Minor > > Here is related code: > {code} > IRealizationFilter filter =3D filters.get(conf); > if (filter =3D=3D null) { > try { > Class clz =3D ClassUtil.for= Name(conf.getQueryRealizationFilter(), IRealizationFilter.class); > filter =3D clz.getConstructor(KylinConfig.class).newInsta= nce(conf); > } catch (Exception e) { > throw new RuntimeException(e); > } > filters.put(conf, filter); > {code} > Two threads may find out there is no filter for conf, they would proceed = with creation of IRealizationFilter instances and try to put into the map. -- This message was sent by Atlassian JIRA (v7.6.3#76005)