From issues-return-20223-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Sep 25 08:52:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0B53180675 for ; Tue, 25 Sep 2018 08:52:03 +0200 (CEST) Received: (qmail 55809 invoked by uid 500); 25 Sep 2018 06:52:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 55799 invoked by uid 99); 25 Sep 2018 06:52:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2018 06:52:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3828AC76CA for ; Tue, 25 Sep 2018 06:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JaKQuS1-ewMm for ; Tue, 25 Sep 2018 06:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7D6EF5F4D8 for ; Tue, 25 Sep 2018 06:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1AF7FE261D for ; Tue, 25 Sep 2018 06:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9BF0723FA7 for ; Tue, 25 Sep 2018 06:52:00 +0000 (UTC) Date: Tue, 25 Sep 2018 06:52:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3588?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1662= 6874#comment-16626874 ]=20 ASF GitHub Bot commented on KYLIN-3588: --------------------------------------- tttMelody opened a new pull request #248: KYLIN-3588, fix potentially dupli= cate putting in RemoveBlackoutRealiz=E2=80=A6 URL: https://github.com/apache/kylin/pull/248 =20 =20 =E2=80=A6ationsRule#getFilterImpl ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map > ----------------------------------------------------------------------- > > Key: KYLIN-3588 > URL: https://issues.apache.org/jira/browse/KYLIN-3588 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Assignee: jiatao.tao > Priority: Minor > > Here is related code: > {code} > IRealizationFilter filter =3D filters.get(conf); > if (filter =3D=3D null) { > try { > Class clz =3D ClassUtil.for= Name(conf.getQueryRealizationFilter(), IRealizationFilter.class); > filter =3D clz.getConstructor(KylinConfig.class).newInsta= nce(conf); > } catch (Exception e) { > throw new RuntimeException(e); > } > filters.put(conf, filter); > {code} > Two threads may find out there is no filter for conf, they would proceed = with creation of IRealizationFilter instances and try to put into the map. -- This message was sent by Atlassian JIRA (v7.6.3#76005)