From issues-return-20286-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Sep 25 18:29:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6ED0018061A for ; Tue, 25 Sep 2018 18:29:03 +0200 (CEST) Received: (qmail 9429 invoked by uid 500); 25 Sep 2018 16:29:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 9420 invoked by uid 99); 25 Sep 2018 16:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2018 16:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2067DC76AE for ; Tue, 25 Sep 2018 16:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PosmRuuRH5Eq for ; Tue, 25 Sep 2018 16:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2E8575F124 for ; Tue, 25 Sep 2018 16:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 99916E0C57 for ; Tue, 25 Sep 2018 16:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4CB3A23F99 for ; Tue, 25 Sep 2018 16:29:00 +0000 (UTC) Date: Tue, 25 Sep 2018 16:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3587) Null value is used in IllegalStateException message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3587?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1662= 7595#comment-16627595 ]=20 ASF GitHub Bot commented on KYLIN-3587: --------------------------------------- codecov-io commented on issue #256: KYLIN-3587 Including tableID in Illegal= StateException messages URL: https://github.com/apache/kylin/pull/256#issuecomment-424412121 =20 =20 # [Codecov](https://codecov.io/gh/apache/kylin/pull/256?src=3Dpr&el=3Dh1= ) Report > Merging [#256](https://codecov.io/gh/apache/kylin/pull/256?src=3Dpr&el= =3Ddesc) into [master](https://codecov.io/gh/apache/kylin/commit/34fd447c2f= 8b1852c530168e344d24f6efce4a3c?src=3Dpr&el=3Ddesc) will **increase** covera= ge by `<.01%`. > The diff coverage is `0%`. =20 [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/256= /graphs/tree.svg?width=3D650&token=3DJawVgbgsVo&height=3D150&src=3Dpr)](htt= ps://codecov.io/gh/apache/kylin/pull/256?src=3Dpr&el=3Dtree) =20 ```diff @@ Coverage Diff @@ ## master #256 +/- ## =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + Coverage 21.11% 21.11% +<.01% =20 + Complexity 4404 4403 -1 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Files 1087 1087 =20 Lines 69878 69878 =20 Branches 10103 10103 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + Hits 14756 14758 +2 =20 + Misses 53723 53721 -2 =20 Partials 1399 1399 ``` =20 =20 | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/256?src=3Dpr&= el=3Dtree) | Coverage =CE=94 | Complexity =CE=94 | | |---|---|---|---| | [.../apache/kylin/metadata/project/ProjectManager.java](https://codeco= v.io/gh/apache/kylin/pull/256/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1tZXRhZGF0= YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvcHJvamVjdC9Qcm9qZWN= 0TWFuYWdlci5qYXZh) | `10.52% <0%> (=C3=B8)` | `7 <0> (=C3=B8)` | :arrow_dow= n: | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codeco= v.io/gh/apache/kylin/pull/256/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1kaWN0aW9u= YXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZ= lcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codeco= v.io/gh/apache/kylin/pull/256/diff?src=3Dpr&el=3Dtree#diff-Y29yZS1jdWJlL3Ny= Yy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR= 1bGVyLmphdmE=3D) | `66.15% <0%> (+2.3%)` | `0% <0%> (=C3=B8)` | :arrow_down= : | =20 ------ =20 [Continue to review full report at Codecov](https://codecov.io/gh/apache= /kylin/pull/256?src=3Dpr&el=3Dcontinue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/c= odecov-delta) > `=CE=94 =3D absolute (impact)`, `=C3=B8 =3D not affected`, = `? =3D missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/256?src= =3Dpr&el=3Dfooter). Last update [34fd447...4c2ddde](https://codecov.io/gh/a= pache/kylin/pull/256?src=3Dpr&el=3Dlastupdated). Read the [comment docs](ht= tps://docs.codecov.io/docs/pull-request-comments). =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Null value is used in IllegalStateException message > --------------------------------------------------- > > Key: KYLIN-3587 > URL: https://issues.apache.org/jira/browse/KYLIN-3587 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Assignee: Yichen Zhou > Priority: Minor > > In ProjectManager : > {code} > TableDesc table =3D metaMgr.getTableDesc(tableId, project= Name); > if (table =3D=3D null) { > throw new IllegalStateException("Cannot find table '"= + table + "' in metadata manager"); > {code} > Since table is null, the exception message is not helpful. > It seems including tableId in the message is better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)