From issues-return-20171-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Mon Sep 24 17:23:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 81582180675 for ; Mon, 24 Sep 2018 17:23:03 +0200 (CEST) Received: (qmail 15053 invoked by uid 500); 24 Sep 2018 15:23:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 15044 invoked by uid 99); 24 Sep 2018 15:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2018 15:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4CA63C6CEC for ; Mon, 24 Sep 2018 15:23:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vGnfVStCqWsm for ; Mon, 24 Sep 2018 15:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 928825F52F for ; Mon, 24 Sep 2018 15:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0F66DE261D for ; Mon, 24 Sep 2018 15:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4745E23FA6 for ; Mon, 24 Sep 2018 15:23:00 +0000 (UTC) Date: Mon, 24 Sep 2018 15:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3582) String comparison should not use == in RecordEvent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625975#comment-16625975 ] ASF GitHub Bot commented on KYLIN-3582: --------------------------------------- asfgit commented on issue #244: KYLIN-3582 String compare should use equals method URL: https://github.com/apache/kylin/pull/244#issuecomment-424014579 Can one of the admins verify this patch? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > String comparison should not use == in RecordEvent > -------------------------------------------------- > > Key: KYLIN-3582 > URL: https://issues.apache.org/jira/browse/KYLIN-3582 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > Here is related code: > {code} > for (RecordReserveKeyEnum reserveKey : RecordReserveKeyEnum.values()) { > if (reserveKey.reserveKey == key) { > {code} > equals() should be used to compare Strings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)