From issues-return-20300-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Wed Sep 26 03:57:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6C883180675 for ; Wed, 26 Sep 2018 03:57:04 +0200 (CEST) Received: (qmail 53859 invoked by uid 500); 26 Sep 2018 01:57:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 53850 invoked by uid 99); 26 Sep 2018 01:57:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2018 01:57:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C89B2C0331 for ; Wed, 26 Sep 2018 01:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1X7CHyKTGVJX for ; Wed, 26 Sep 2018 01:57:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F212D5F4D8 for ; Wed, 26 Sep 2018 01:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0B82FE2072 for ; Wed, 26 Sep 2018 01:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5D70323FA2 for ; Wed, 26 Sep 2018 01:57:00 +0000 (UTC) Date: Wed, 26 Sep 2018 01:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3356) Constant in SecretKeySpec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3356?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1662= 8151#comment-16628151 ]=20 ASF GitHub Bot commented on KYLIN-3356: --------------------------------------- asfgit commented on issue #258: KYLIN-3356 Constant in SecretKeySpec URL: https://github.com/apache/kylin/pull/258#issuecomment-424558579 =20 =20 Can one of the admins verify this patch? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Constant in SecretKeySpec > ------------------------- > > Key: KYLIN-3356 > URL: https://issues.apache.org/jira/browse/KYLIN-3356 > Project: Kylin > Issue Type: Improvement > Reporter: liyang > Priority: Minor > Fix For: v2.6.0 > > > Reported by=C2=A0Rumen Paletov :=20 > As part of some research about the common crypto mistakes that developer= s > make <[https://cs.ucsb.edu/~chris/research/doc/ccs13_cryptolint.pdf]>, I > noticed that your application has one of them. > =20 > In particular, there's a violation of Rule 3 in > org.apache.kylin.common.util.EncryptUtil > <[https://github.com/apache/kylin/blob/5552164ba09eba989b9ddccdf3f1e4f83= ed0b799/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.= java#L36]>. > That is, SecretKeySpec is being initialized with a constant key > <[https://github.com/apache/kylin/blob/5552164ba09eba989b9ddccdf3f1e4f83= ed0b799/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.= java#L30]> > instead of a randomly generated one. > =20 > One solution would be to generate a key using SecureRandom: > =20 > > byte[] key =3D new byte[16]; > > new SecureRandom.nextBytes(key); > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)