kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3603) HBase connection isn't closed in UpdateHTableHostCLI
Date Sat, 29 Sep 2018 02:01:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632722#comment-16632722
] 

ASF GitHub Bot commented on KYLIN-3603:
---------------------------------------

coveralls commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI
URL: https://github.com/apache/kylin/pull/271#issuecomment-425606821
 
 
   ## Pull Request Test Coverage Report for [Build 3706](https://coveralls.io/builds/19259026)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **6** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.001%**) to **23.17%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/UpdateHTableHostCLI.java](https://coveralls.io/builds/19259026/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FUpdateHTableHostCLI.java#L62)
| 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **3** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/UpdateHTableHostCLI.java](https://coveralls.io/builds/19259026/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FUpdateHTableHostCLI.java#L66)
| 1 | 0.0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/19259026/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19259026/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/19259026/badge)](https://coveralls.io/builds/19259026)
|
   | :-- | --: |
   | Change from base [Build 3703](https://coveralls.io/builds/19245700): |  0.001% |
   | Covered Lines: | 16160 |
   | Relevant Lines: | 69745 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> HBase connection isn't closed in UpdateHTableHostCLI
> ----------------------------------------------------
>
>                 Key: KYLIN-3603
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3603
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Lijun Cao
>            Assignee: Lijun Cao
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> The HBase connection is only used in the constructor to get an *_Admin_* , it should
be closed after used.
> {code:java}
> public UpdateHTableHostCLI(List<String> htables, String oldHostValue) throws IOException
{
>         this.htables = htables;
>         this.oldHostValue = oldHostValue;
>         Connection conn = ConnectionFactory.createConnection(HBaseConfiguration.create());
>         hbaseAdmin = conn.getAdmin();
>         this.kylinConfig = KylinConfig.getInstanceFromEnv();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message