kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
Date Thu, 27 Sep 2018 15:19:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630603#comment-16630603
] 

ASF GitHub Bot commented on KYLIN-3588:
---------------------------------------

codecov-io edited a comment on issue #248: KYLIN-3588, fix potentially duplicate putting in
RemoveBlackoutRealiz…
URL: https://github.com/apache/kylin/pull/248#issuecomment-424234716
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@9ae03f6`). [Click
here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/248/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #248   +/-   ##
   =========================================
     Coverage          ?   21.15%           
     Complexity        ?     4405           
   =========================================
     Files             ?     1086           
     Lines             ?    69745           
     Branches          ?    10088           
   =========================================
     Hits              ?    14758           
     Misses            ?    53588           
     Partials          ?     1399
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../routing/rules/RemoveBlackoutRealizationsRule.java](https://codecov.io/gh/apache/kylin/pull/248/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JvdXRpbmcvcnVsZXMvUmVtb3ZlQmxhY2tvdXRSZWFsaXphdGlvbnNSdWxlLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=footer).
Last update [9ae03f6...46861d4](https://codecov.io/gh/apache/kylin/pull/248?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
> -----------------------------------------------------------------------
>
>                 Key: KYLIN-3588
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3588
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>
> Here is related code:
> {code}
>         IRealizationFilter filter = filters.get(conf);
>         if (filter == null) {
>             try {
>                 Class<? extends IRealizationFilter> clz = ClassUtil.forName(conf.getQueryRealizationFilter(),
IRealizationFilter.class);
>                 filter = clz.getConstructor(KylinConfig.class).newInstance(conf);
>             } catch (Exception e) {
>                 throw new RuntimeException(e);
>             }
>             filters.put(conf, filter);
> {code}
> Two threads may find out there is no filter for conf, they would proceed with creation
of IRealizationFilter instances and try to put into the map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message