kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
Date Thu, 27 Sep 2018 14:54:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630557#comment-16630557
] 

ASF GitHub Bot commented on KYLIN-3588:
---------------------------------------

tttMelody commented on a change in pull request #248: KYLIN-3588, fix potentially duplicate
putting in RemoveBlackoutRealiz…
URL: https://github.com/apache/kylin/pull/248#discussion_r220956979
 
 

 ##########
 File path: query/src/main/java/org/apache/kylin/query/routing/rules/RemoveBlackoutRealizationsRule.java
 ##########
 @@ -58,14 +58,16 @@ public static boolean accept(IRealization real) {
     
     private static IRealizationFilter getFilterImpl(KylinConfig conf) {
         IRealizationFilter filter = filters.get(conf);
-        if (filter == null) {
-            try {
-                Class<? extends IRealizationFilter> clz = ClassUtil.forName(conf.getQueryRealizationFilter(),
IRealizationFilter.class);
-                filter = clz.getConstructor(KylinConfig.class).newInstance(conf);
-            } catch (Exception e) {
-                throw new RuntimeException(e);
+        synchronized (RemoveBlackoutRealizationsRule.class) {
 
 Review comment:
   Thanks shaofeng! I'll refine this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
> -----------------------------------------------------------------------
>
>                 Key: KYLIN-3588
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3588
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>
> Here is related code:
> {code}
>         IRealizationFilter filter = filters.get(conf);
>         if (filter == null) {
>             try {
>                 Class<? extends IRealizationFilter> clz = ClassUtil.forName(conf.getQueryRealizationFilter(),
IRealizationFilter.class);
>                 filter = clz.getConstructor(KylinConfig.class).newInstance(conf);
>             } catch (Exception e) {
>                 throw new RuntimeException(e);
>             }
>             filters.put(conf, filter);
> {code}
> Two threads may find out there is no filter for conf, they would proceed with creation
of IRealizationFilter instances and try to put into the map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message