kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3587) Null value is used in IllegalStateException message
Date Tue, 25 Sep 2018 16:29:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627595#comment-16627595
] 

ASF GitHub Bot commented on KYLIN-3587:
---------------------------------------

codecov-io commented on issue #256: KYLIN-3587 Including tableID in IllegalStateException
messages
URL: https://github.com/apache/kylin/pull/256#issuecomment-424412121
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=h1) Report
   > Merging [#256](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/34fd447c2f8b1852c530168e344d24f6efce4a3c?src=pr&el=desc)
will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/256/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #256      +/-   ##
   ============================================
   + Coverage     21.11%   21.11%   +<.01%     
   + Complexity     4404     4403       -1     
   ============================================
     Files          1087     1087              
     Lines         69878    69878              
     Branches      10103    10103              
   ============================================
   + Hits          14756    14758       +2     
   + Misses        53723    53721       -2     
     Partials       1399     1399
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/kylin/metadata/project/ProjectManager.java](https://codecov.io/gh/apache/kylin/pull/256/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvcHJvamVjdC9Qcm9qZWN0TWFuYWdlci5qYXZh)
| `10.52% <0%> (ø)` | `7 <0> (ø)` | :arrow_down: |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/256/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/256/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=footer).
Last update [34fd447...4c2ddde](https://codecov.io/gh/apache/kylin/pull/256?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Null value is used in IllegalStateException message
> ---------------------------------------------------
>
>                 Key: KYLIN-3587
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3587
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Yichen Zhou
>            Priority: Minor
>
> In ProjectManager :
> {code}
>                 TableDesc table = metaMgr.getTableDesc(tableId, projectName);
>                 if (table == null) {
>                     throw new IllegalStateException("Cannot find table '" + table + "'
in metadata manager");
> {code}
> Since table is null, the exception message is not helpful.
> It seems including tableId in the message is better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message