kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3587) Null value is used in IllegalStateException message
Date Tue, 25 Sep 2018 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627569#comment-16627569
] 

ASF GitHub Bot commented on KYLIN-3587:
---------------------------------------

asfgit commented on issue #256: KYLIN-3587 Including tableID in IllegalStateException messages
URL: https://github.com/apache/kylin/pull/256#issuecomment-424403997
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Null value is used in IllegalStateException message
> ---------------------------------------------------
>
>                 Key: KYLIN-3587
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3587
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Yichen Zhou
>            Priority: Minor
>
> In ProjectManager :
> {code}
>                 TableDesc table = metaMgr.getTableDesc(tableId, projectName);
>                 if (table == null) {
>                     throw new IllegalStateException("Cannot find table '" + table + "'
in metadata manager");
> {code}
> Since table is null, the exception message is not helpful.
> It seems including tableId in the message is better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message