kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3586) Boxing/unboxing to parse a primitive is suboptimal
Date Fri, 28 Sep 2018 02:03:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631254#comment-16631254
] 

ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------

codecov-io commented on issue #269: KYLIN-3586 Fix eight primitive boxing/unboxing problem.
URL: https://github.com/apache/kylin/pull/269#issuecomment-425296989
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=h1) Report
   > Merging [#269](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/9ae03f6d79d3f7b36f3600208d07d1d5c6856320?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
   > The diff coverage is `15.51%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/269/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #269      +/-   ##
   ============================================
   - Coverage     21.15%   21.15%   -0.01%     
   + Complexity     4406     4405       -1     
   ============================================
     Files          1086     1086              
     Lines         69743    69743              
     Branches      10088    10088              
   ============================================
   - Hits          14755    14754       -1     
   - Misses        53587    53588       +1     
     Partials       1401     1401
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../java/org/apache/kylin/rest/job/HybridCubeCLI.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL0h5YnJpZEN1YmVDTEkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...in/java/org/apache/kylin/metadata/tuple/Tuple.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvdHVwbGUvVHVwbGUuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...age/hbase/lookup/LookupTableHFilesBulkLoadJob.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvTG9va3VwVGFibGVIRmlsZXNCdWxrTG9hZEpvYi5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/kylin/metadata/filter/UDF/MassInTupleFilter.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvZmlsdGVyL1VERi9NYXNzSW5UdXBsZUZpbHRlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...java/org/apache/kylin/common/util/MailService.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01haWxTZXJ2aWNlLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...java/org/apache/kylin/tool/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9NZXRhZGF0YUNsZWFudXBKb2IuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...n/java/org/apache/kylin/tool/CubeMetaIngester.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWV0YUluZ2VzdGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ache/kylin/metadata/filter/ExtractTupleFilter.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvZmlsdGVyL0V4dHJhY3RUdXBsZUZpbHRlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/kylin/pull/269/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=footer).
Last update [9ae03f6...6b293c9](https://codecov.io/gh/apache/kylin/pull/269?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
>                 Key: KYLIN-3586
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3586
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Lijun Cao
>            Priority: Major
>             Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
>             int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to valIdx.
> Integer.parseInt() should be used instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message