kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3582) String comparison should not use == in RecordEvent
Date Mon, 24 Sep 2018 15:23:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625975#comment-16625975
] 

ASF GitHub Bot commented on KYLIN-3582:
---------------------------------------

asfgit commented on issue #244: KYLIN-3582 String compare should use equals method
URL: https://github.com/apache/kylin/pull/244#issuecomment-424014579
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> String comparison should not use == in RecordEvent
> --------------------------------------------------
>
>                 Key: KYLIN-3582
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3582
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>             for (RecordReserveKeyEnum reserveKey : RecordReserveKeyEnum.values()) {
>                 if (reserveKey.reserveKey == key) {
> {code}
> equals() should be used to compare Strings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message