kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3567) Change scala dependency to provided
Date Fri, 21 Sep 2018 03:27:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623012#comment-16623012
] 

ASF GitHub Bot commented on KYLIN-3567:
---------------------------------------

shaofengshi closed pull request #239: KYLIN-3567 Change scala dependency scope to provided
URL: https://github.com/apache/kylin/pull/239
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine-spark/pom.xml b/engine-spark/pom.xml
index 9516b19ffe..26a3ad7c62 100644
--- a/engine-spark/pom.xml
+++ b/engine-spark/pom.xml
@@ -104,16 +104,19 @@
         <dependency>
             <groupId>org.scala-lang</groupId>
             <artifactId>scala-library</artifactId>
+            <scope>provided</scope>
         </dependency>
 
         <dependency>
             <groupId>org.scala-lang</groupId>
             <artifactId>scala-compiler</artifactId>
+            <scope>provided</scope>
         </dependency>
 
         <dependency>
             <groupId>org.scala-lang</groupId>
             <artifactId>scala-reflect</artifactId>
+            <scope>provided</scope>
         </dependency>
     </dependencies>
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Change scala dependency to provided
> -----------------------------------
>
>                 Key: KYLIN-3567
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3567
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Chao Long
>            Assignee: Chao Long
>            Priority: Minor
>             Fix For: v2.5.1
>
>
> The scope of scala dependency in "engine-spark" module should be "provided".
> <dependency>
>  <groupId>org.scala-lang</groupId>
>  <artifactId>scala-library</artifactId>
> </dependency>
> <dependency>
>  <groupId>org.scala-lang</groupId>
>  <artifactId>scala-compiler</artifactId>
> </dependency>
> <dependency>
>  <groupId>org.scala-lang</groupId>
>  <artifactId>scala-reflect</artifactId>
> </dependency>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message