kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube
Date Tue, 18 Sep 2018 05:15:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618488#comment-16618488
] 

ASF GitHub Bot commented on KYLIN-3527:
---------------------------------------

luguosheng1314 closed pull request #234: KYLIN-3527 fix hybrid couldn't save when there is
only 1 cube
URL: https://github.com/apache/kylin/pull/234
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/js/controllers/hybridInstanceSchema.js b/webapp/app/js/controllers/hybridInstanceSchema.js
index c4f61b496a..668f6dcc78 100644
--- a/webapp/app/js/controllers/hybridInstanceSchema.js
+++ b/webapp/app/js/controllers/hybridInstanceSchema.js
@@ -118,9 +118,8 @@ KylinApp.controller('HybridInstanceSchema', function (
     var schema = getSchema();
 
     return Object.keys(schema).every(function(key) {
-      // Array.length for checking select cubes count >= 2
       // otherwise checking empty value
-      return schema[key] instanceof Array ? schema[key].length > 1 : schema[key];
+      return !!schema[key];
     });
   };
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> ----------------------------------------------
>
>                 Key: KYLIN-3527
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3527
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.5.0
>            Reporter: Shaofeng SHI
>            Assignee: Roger
>            Priority: Minor
>             Fix For: v2.5.1
>
>         Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, but I found
when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message