kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3496) Make calcite extras props available in JDBC Driver
Date Tue, 25 Sep 2018 13:02:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627316#comment-16627316
] 

ASF GitHub Bot commented on KYLIN-3496:
---------------------------------------

coveralls commented on issue #255: KYLIN-3496 Make calcite extras props available in JDBC
Driver
URL: https://github.com/apache/kylin/pull/255#issuecomment-424333526
 
 
   ## Pull Request Test Coverage Report for [Build 3655](https://coveralls.io/builds/19177291)
   
   * **19** of **34**   **(55.88%)**  changed or added relevant lines in **5** files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **23.134%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [jdbc/src/main/java/org/apache/kylin/jdbc/KylinResultSet.java](https://coveralls.io/builds/19177291/source?filename=jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjdbc%2FKylinResultSet.java#L104)
| 16 | 18 | 88.89%
   | [core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/19177291/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L168)
| 0 | 13 | 0.0%
   <!-- | **Total:** | **19** | **34** | **55.88%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultFetcherRunner.java](https://coveralls.io/builds/19177291/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultFetcherRunner.java#L71)
| 1 | 79.55% |
   | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/19177291/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
| 1 | 81.08% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19177291/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
   <!-- | **Total:** | **7** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/19177291/badge)](https://coveralls.io/builds/19177291)
|
   | :-- | --: |
   | Change from base [Build 3650](https://coveralls.io/builds/19173507): |  0.01% |
   | Covered Lines: | 16173 |
   | Relevant Lines: | 69910 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make calcite extras props available in JDBC Driver
> --------------------------------------------------
>
>                 Key: KYLIN-3496
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3496
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Driver - JDBC, Query Engine
>            Reporter: Ian Hu
>            Assignee: Ian Hu
>            Priority: Minor
>              Labels: features
>             Fix For: v2.6.0
>
>
> Like #KYLIN-3475 , calcite can be configured in the server by `kylin.properties`, while
the JDBC Driver is closer with the real query sql generation, and if calcite can be configured
by jdbc client there would be more flexable to various situation. Like quoting as mysql or
use mysql-specified SQL grammer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message