From issues-return-19253-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Fri Aug 24 04:40:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6324518061A for ; Fri, 24 Aug 2018 04:40:03 +0200 (CEST) Received: (qmail 72944 invoked by uid 500); 24 Aug 2018 02:40:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 72935 invoked by uid 99); 24 Aug 2018 02:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2018 02:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 181F1180847 for ; Fri, 24 Aug 2018 02:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rjGWOq8bDGVX for ; Fri, 24 Aug 2018 02:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2724D5F396 for ; Fri, 24 Aug 2018 02:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D1F8E0E1D for ; Fri, 24 Aug 2018 02:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D4D12469F for ; Fri, 24 Aug 2018 02:40:00 +0000 (UTC) Date: Fri, 24 Aug 2018 02:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3499) resource inconsistent caused by hbase rpc timeout MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591069#comment-16591069 ] ASF GitHub Bot commented on KYLIN-3499: --------------------------------------- momoxixi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java URL: https://github.com/apache/kylin/pull/198#issuecomment-415633716 Hi shaofengshi, You get my point, and here is my opinion for two comments,: 1. I consider Embedded `try-catch` is a compromise plan, or it would modify more code. 2. `IOException` maybe a more smarter choice, but after reading hbase source code `RetriesExhaustedException` is the one exception that need to recheck. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > resource inconsistent caused by hbase rpc timeout > ------------------------------------------------- > > Key: KYLIN-3499 > URL: https://issues.apache.org/jira/browse/KYLIN-3499 > Project: Kylin > Issue Type: Bug > Components: Storage - HBase > Affects Versions: all > Reporter: ulysses you > Priority: Major > Fix For: Future > > Attachments: ca7a61b2fdbfc321e7c896c3d34fd4d4c48e3eed.patch, error.png > > > KYLIN use hbase to persist resouce metadata. When hbase rpc timeout, kylin would rollback the resource timestamp. It caused resource inconsistent between kylin's memory and hbase if hbase already put the resource. -- This message was sent by Atlassian JIRA (v7.6.3#76005)