From issues-return-19038-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Tue Aug 7 17:06:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37EAC180676 for ; Tue, 7 Aug 2018 17:06:04 +0200 (CEST) Received: (qmail 23803 invoked by uid 500); 7 Aug 2018 15:06:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 23794 invoked by uid 99); 7 Aug 2018 15:06:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 15:06:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D5151C1D76 for ; Tue, 7 Aug 2018 15:06:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BxoyLEjLHyLY for ; Tue, 7 Aug 2018 15:06:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B0E045F516 for ; Tue, 7 Aug 2018 15:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DDCCFE2618 for ; Tue, 7 Aug 2018 15:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3EE0623FA1 for ; Tue, 7 Aug 2018 15:06:00 +0000 (UTC) Date: Tue, 7 Aug 2018 15:06:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3481) Kylin Jdbc: Shaded dependencies should not be transitive MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3481?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1657= 1811#comment-16571811 ]=20 ASF subversion and git services commented on KYLIN-3481: -------------------------------------------------------- Commit 6adf1b396c2ca72daf55a94f28092cbd8909626e in kylin's branch refs/head= s/master from [~hu2008yinxiang] [ https://gitbox.apache.org/repos/asf?p=3Dkylin.git;h=3D6adf1b3 ] KYLIN-3481 Shaded dependencies should be optional > Kylin Jdbc: Shaded dependencies should not be transitive > -------------------------------------------------------- > > Key: KYLIN-3481 > URL: https://issues.apache.org/jira/browse/KYLIN-3481 > Project: Kylin > Issue Type: Improvement > Components: Driver - JDBC > Affects Versions: v2.4.0 > Reporter: Ian Hu > Assignee: Ian Hu > Priority: Minor > Fix For: v2.5.0 > > > kylin-jdbc use dependencies as shaded, so they should not be transitive. > As far as I known, SHADE a dependency to avoid dependency conflict, but a= t v2.4.0, the dependencies in kylin-jdbc are default compile scope and are = transitive resolved, that may cause some dependency conflicts. > We should mark shaded dependencies as optional > =C2=A0 > There are two solutions about the fixation: > # mark dependency as `optional` > # or change the dependency scope to provided, and add shade artifactSets= with include > {code:java} > > org.apache.httpcomponents > httpclient > true // add this > > // =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D or =3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > org.apache.httpcomponents > httpclient > provided > > // and > > > org.slf4j:jcl-over-slf4j:* > > > org.apache.httpcomponents:httpclient:* // forc= e include provided scope > org.apache.calcite.avatica:avatica-core:* // f= orce include provided scope=20 > > {code} > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)