From issues-return-19043-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Wed Aug 8 07:52:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05F6A18077A for ; Wed, 8 Aug 2018 07:52:03 +0200 (CEST) Received: (qmail 98598 invoked by uid 500); 8 Aug 2018 05:52:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 98589 invoked by uid 99); 8 Aug 2018 05:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 05:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B626CC05DC for ; Wed, 8 Aug 2018 05:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ufE8Aeeyxh7Y for ; Wed, 8 Aug 2018 05:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 42D915F493 for ; Wed, 8 Aug 2018 05:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C57FE0110 for ; Wed, 8 Aug 2018 05:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3086723F9C for ; Wed, 8 Aug 2018 05:52:00 +0000 (UTC) Date: Wed, 8 Aug 2018 05:52:00 +0000 (UTC) From: "Shaofeng SHI (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (KYLIN-3476) Fix TupleExpression verification when parsing sql MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3476. --------------------------------- Resolution: Fixed > Fix TupleExpression verification when parsing sql > ------------------------------------------------- > > Key: KYLIN-3476 > URL: https://issues.apache.org/jira/browse/KYLIN-3476 > Project: Kylin > Issue Type: Bug > Affects Versions: v2.4.0 > Reporter: Zhong Yanghong > Assignee: Zhong Yanghong > Priority: Major > Fix For: v2.4.1, v2.5.0 > > Attachments: APACHE-KYLIN-3476.patch, b134-12adb0383568.png, image-2018-08-06-17-58-18-760.png > > > Previously there's a validation check for sql, since dynamic column does not support {{sum(col1/col2)}}. However, if the sql has a subquery and {{sum(col1/col2)}} is in the main query rather than the sub-query, this should be OK. One example is as follows: > {code} > select T1.D1, sum(T1.gmv/T2.gmv) > from > (select D1, D2, sum(M1) as gmv > from T > group by D1, D2) T1 > inner join > (select D1, D2, sum(M2) as gmv > from T > group by D1, D2) T2 > on T1.D1 = T2.D1 > group by T1.D1 > {code} > Since the outside {{sum(T1.gmv/T2.gmv)}} is handled by calcite rather than Kylin, it's OK and should not go through the verification. -- This message was sent by Atlassian JIRA (v7.6.3#76005)