kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3481) Kylin Jdbc: Shaded dependencies should not be transitive
Date Tue, 07 Aug 2018 15:06:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571811#comment-16571811
] 

ASF subversion and git services commented on KYLIN-3481:
--------------------------------------------------------

Commit 6adf1b396c2ca72daf55a94f28092cbd8909626e in kylin's branch refs/heads/master from [~hu2008yinxiang]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6adf1b3 ]

KYLIN-3481 Shaded dependencies should be optional

> Kylin Jdbc: Shaded dependencies should not be transitive
> --------------------------------------------------------
>
>                 Key: KYLIN-3481
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3481
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Driver - JDBC
>    Affects Versions: v2.4.0
>            Reporter: Ian Hu
>            Assignee: Ian Hu
>            Priority: Minor
>             Fix For: v2.5.0
>
>
> kylin-jdbc use dependencies as shaded, so they should not be transitive.
> As far as I known, SHADE a dependency to avoid dependency conflict, but at v2.4.0, the
dependencies in kylin-jdbc are default compile scope and are transitive resolved, that may
cause some dependency conflicts.
> We should mark shaded dependencies as optional
>  
> There are two solutions about the fixation:
>  # mark dependency as `optional`
>  # or change the dependency scope to provided, and add shade artifactSets with include
> {code:java}
> <dependency>
>     <groupId>org.apache.httpcomponents</groupId>
>     <artifactId>httpclient</artifactId>
>     <optional>true</optional> // add this
> </dependency>
> // ============= or =============
> <dependency>
>     <groupId>org.apache.httpcomponents</groupId>
>     <artifactId>httpclient</artifactId>
>     <scope>provided</scope>
> </dependency>
> // and
> <artifactSet>
>     <excludes>
>         <exclude>org.slf4j:jcl-over-slf4j:*</exclude>
>     </excludes>
>     <includes>
>         <include>org.apache.httpcomponents:httpclient:*</include> // force
include provided scope
>         <include>org.apache.calcite.avatica:avatica-core:*</include> // force
include provided scope 
>     </includes>
> </artifactSet>{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message