kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3481) Kylin Jdbc: Shaded dependencies should not be transitive
Date Tue, 07 Aug 2018 15:06:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571810#comment-16571810
] 

ASF GitHub Bot commented on KYLIN-3481:
---------------------------------------

shaofengshi closed pull request #185: KYLIN-3481 Shaded dependencies should be optional
URL: https://github.com/apache/kylin/pull/185
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/jdbc/pom.xml b/jdbc/pom.xml
index 466cf1328b..661356c412 100644
--- a/jdbc/pom.xml
+++ b/jdbc/pom.xml
@@ -39,10 +39,12 @@
         <dependency>
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpclient</artifactId>
+            <optional>true</optional>
         </dependency>
         <dependency>
             <groupId>org.apache.calcite.avatica</groupId>
             <artifactId>avatica-core</artifactId>
+            <optional>true</optional>
         </dependency>
         <dependency>
             <groupId>junit</groupId>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kylin Jdbc: Shaded dependencies should not be transitive
> --------------------------------------------------------
>
>                 Key: KYLIN-3481
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3481
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Driver - JDBC
>    Affects Versions: v2.4.0
>            Reporter: Ian Hu
>            Assignee: Ian Hu
>            Priority: Minor
>             Fix For: v2.5.0
>
>
> kylin-jdbc use dependencies as shaded, so they should not be transitive.
> As far as I known, SHADE a dependency to avoid dependency conflict, but at v2.4.0, the
dependencies in kylin-jdbc are default compile scope and are transitive resolved, that may
cause some dependency conflicts.
> We should mark shaded dependencies as optional
>  
> There are two solutions about the fixation:
>  # mark dependency as `optional`
>  # or change the dependency scope to provided, and add shade artifactSets with include
> {code:java}
> <dependency>
>     <groupId>org.apache.httpcomponents</groupId>
>     <artifactId>httpclient</artifactId>
>     <optional>true</optional> // add this
> </dependency>
> // ============= or =============
> <dependency>
>     <groupId>org.apache.httpcomponents</groupId>
>     <artifactId>httpclient</artifactId>
>     <scope>provided</scope>
> </dependency>
> // and
> <artifactSet>
>     <excludes>
>         <exclude>org.slf4j:jcl-over-slf4j:*</exclude>
>     </excludes>
>     <includes>
>         <include>org.apache.httpcomponents:httpclient:*</include> // force
include provided scope
>         <include>org.apache.calcite.avatica:avatica-core:*</include> // force
include provided scope 
>     </includes>
> </artifactSet>{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message