kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3434) Support prepare statement in Kylin server side
Date Mon, 02 Jul 2018 11:01:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529710#comment-16529710
] 

ASF GitHub Bot commented on KYLIN-3434:
---------------------------------------

codecov-io commented on issue #160: KYLIN-3434 Support prepare statement in Kylin server side
URL: https://github.com/apache/kylin/pull/160#issuecomment-401767780
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=h1) Report
   > Merging [#160](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/7c1d9026a00e9da0845c2fad13a5dd0fcd851939?src=pr&el=desc)
will **decrease** coverage by `0.05%`.
   > The diff coverage is `0.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/160/graphs/tree.svg?token=JawVgbgsVo&width=650&src=pr&height=150)](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #160      +/-   ##
   ============================================
   - Coverage     22.44%   22.39%   -0.06%     
   - Complexity     4154     4155       +1     
   ============================================
     Files          1034     1034              
     Lines         62181    62271      +90     
     Branches       8907     8921      +14     
   ============================================
   - Hits          13957    13946      -11     
   - Misses        46903    46998      +95     
   - Partials       1321     1327       +6
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.57% <0%> (-0.06%)` | `35 <0> (ø)` | |
   | [.../apache/kylin/metadata/project/ProjectManager.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvcHJvamVjdC9Qcm9qZWN0TWFuYWdlci5qYXZh)
| `10.52% <0%> (-0.21%)` | `7 <0> (ø)` | |
   | [...g/apache/kylin/rest/request/PrepareSqlRequest.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvcmVxdWVzdC9QcmVwYXJlU3FsUmVxdWVzdC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=)
| `40.8% <100%> (+0.1%)` | `42 <0> (ø)` | :arrow_down: |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `66.56% <0%> (-3.65%)` | `7% <0%> (ø)` | |
   | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=)
| `64.46% <0%> (+0.13%)` | `176% <0%> (+1%)` | :arrow_up: |
   | [.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh)
| `39.11% <0%> (+0.36%)` | `51% <0%> (+1%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/160/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=footer).
Last update [7c1d902...08d657e](https://codecov.io/gh/apache/kylin/pull/160?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support prepare statement in Kylin server side
> ----------------------------------------------
>
>                 Key: KYLIN-3434
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3434
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Ma Gang
>            Assignee: Ma Gang
>            Priority: Major
>
> Kylin use calcite as sql engine, when a sql comes to Kylin server, it requires to be
parsed, optimized, code gen, and then query Kylin's cube storage, the previous 3 steps often
take 50-150 ms to complete(depends on the complexity of the sql). If we support to cache
the parsed result in Kylin server, the 3 steps will be saved.
> The idea is to cache calcite's PreparedStatement object and related OLAPContexts in the
server side, when the prepare request comes with the same sql, reuse the PreparedStatement
to do the execution. Since the PreparedStatement is not thread safe, so I planned to use
ObjectPool to cache the PreparedStatement.(use apache commons-pool lib)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message