kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3434) Support prepare statement in Kylin server side
Date Mon, 02 Jul 2018 10:55:02 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529704#comment-16529704
] 

ASF GitHub Bot commented on KYLIN-3434:
---------------------------------------

coveralls commented on issue #160: KYLIN-3434 Support prepare statement in Kylin server side
URL: https://github.com/apache/kylin/pull/160#issuecomment-401765161
 
 
   ## Pull Request Test Coverage Report for [Build 3287](https://coveralls.io/builds/17788389)
   
   * **1** of **133**   **(0.75%)**  changed or added relevant lines in **5** files are covered.
   * **10** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **24.53%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/17788389/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1381)
| 0 | 2 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectManager.java](https://coveralls.io/builds/17788389/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fproject%2FProjectManager.java#L365)
| 0 | 4 | 0.0%
   | [server-base/src/main/java/org/apache/kylin/rest/request/PrepareSqlRequest.java](https://coveralls.io/builds/17788389/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Frequest%2FPrepareSqlRequest.java#L31)
| 0 | 4 | 0.0%
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/17788389/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L157)
| 0 | 122 | 0.0%
   <!-- | **Total:** | **1** | **133** | **0.75%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/17788389/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L317)
| 1 | 81.08% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/17788389/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L533)
| 2 | 0.0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/17788389/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193)
| 7 | 76.29% |
   <!-- | **Total:** | **10** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/17788389/badge)](https://coveralls.io/builds/17788389)
|
   | :-- | --: |
   | Change from base [Build 3285](https://coveralls.io/builds/17783358): |  -0.04% |
   | Covered Lines: | 15275 |
   | Relevant Lines: | 62271 |
   
   ---
   ##### šŸ’›  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support prepare statement in Kylin server side
> ----------------------------------------------
>
>                 Key: KYLIN-3434
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3434
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Ma Gang
>            Assignee: Ma Gang
>            Priority: Major
>
> Kylin use calcite as sql engine, when a sql comes to Kylin server, it requires to be
parsed, optimized, code gen, and then query Kylin's cube storage, the previous 3 steps often
take 50-150 ms to complete(depends on the complexity of the sql). If we supportĀ to cache
the parsed result in Kylin server, theĀ 3 steps will be saved.
> The idea is to cache calcite's PreparedStatement object and related OLAPContexts in the
server side, when the prepare request comes with the same sql, reuse the PreparedStatement
to do the execution. Since theĀ PreparedStatement is not thread safe, so I planned to use
ObjectPool to cache theĀ PreparedStatement.(use apache commons-pool lib)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message