kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3418) User interface for hybrid model
Date Wed, 25 Jul 2018 02:30:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555035#comment-16555035
] 

ASF GitHub Bot commented on KYLIN-3418:
---------------------------------------

shaofengshi commented on a change in pull request #174: KYLIN-3418 adjust hybrid API
URL: https://github.com/apache/kylin/pull/174#discussion_r204965852
 
 

 ##########
 File path: server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java
 ##########
 @@ -105,6 +105,18 @@ protected void execute(OptionsHelper optionsHelper) throws Exception
{
         String projectName = optionsHelper.getOptionValue(OPTION_PROJECT);
         String modelName = optionsHelper.getOptionValue(OPTION_MODEL);
         String cubeNamesStr = optionsHelper.getOptionValue(OPTION_CUBES);
+
+        HybridInstance hybridInstance = hybridManager.getHybridInstance(hybridName);
+
+        if ("delete".equals(action)) {
+            if (hybridInstance == null) {
+                throw new RuntimeException("The Hybrid Cube doesn't exist, could not delete:
" + hybridName);
 
 Review comment:
   Please use illegal argument exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> User interface for hybrid model
> -------------------------------
>
>                 Key: KYLIN-3418
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3418
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Web 
>            Reporter: Shaofeng SHI
>            Assignee: Roger
>            Priority: Major
>             Fix For: v2.5.0
>
>
> Hybrid model is useful for model change. While now there is no entry for it from GUI,
this makes many users don't see such feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message