kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "liyang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3399) Leaked lookup table in DictionaryGeneratorCLI#processSegment
Date Sun, 10 Jun 2018 01:10:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507222#comment-16507222
] 

liyang commented on KYLIN-3399:
-------------------------------

The {{cubeMgr.getLookupTable(cubeSeg, join);}} is to check if any exception will be thrown
by test getting the lookup table. Could use some comment if it confuses reader.

> Leaked lookup table in DictionaryGeneratorCLI#processSegment
> ------------------------------------------------------------
>
>                 Key: KYLIN-3399
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3399
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Major
>
> {code}
>         for (TableRef lookup : toCheckLookup) {
>             logger.info("Checking snapshot of " + lookup);
>             JoinDesc join = cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
>             cubeMgr.getLookupTable(cubeSeg, join);
> {code}
> The lookup table from the last line doesn't seem to be used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message