kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3161) Enforce global dictionary for bitmap count distinct column
Date Sun, 03 Jun 2018 14:03:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499431#comment-16499431
] 

ASF GitHub Bot commented on KYLIN-3161:
---------------------------------------

shaofengshi commented on a change in pull request #147: KYLIN-3161 Enforce global dictionary
for bitmap count distinct column…
URL: https://github.com/apache/kylin/pull/147#discussion_r192590806
 
 

 ##########
 File path: core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java
 ##########
 @@ -89,17 +100,32 @@ public void validate(CubeDesc cubeDesc, ValidateContext context) {
                 return;
             }
 
+            if (StringUtils.isNotEmpty(builderClass) && !builderClass.equalsIgnoreCase(GlobalDictionaryBuilder.class.getName())
&& bitmapMeasures.containsKey(dictCol) && !dictCol.getColumnDesc().getType().isIntegerFamily()){
 
 Review comment:
   "builderClass" can be empty, which would means the normal dictionary. So this case should
also be checked.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enforce global dictionary for bitmap count distinct column
> ----------------------------------------------------------
>
>                 Key: KYLIN-3161
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3161
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Measure - Count Distinct
>            Reporter: Shaofeng SHI
>            Priority: Major
>
> For bitmap based count distinct column (as the data type is not int), a Global dictionary
is required. But now user can use normal dictionary, which may cause incorrect result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message