From issues-return-17488-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Sun May 6 15:04:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F1901180674 for ; Sun, 6 May 2018 15:04:03 +0200 (CEST) Received: (qmail 36636 invoked by uid 500); 6 May 2018 13:04:02 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 36627 invoked by uid 99); 6 May 2018 13:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 May 2018 13:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1A7DAC6680 for ; Sun, 6 May 2018 13:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id T5obX0vLMZVW for ; Sun, 6 May 2018 13:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3FD8F5FB95 for ; Sun, 6 May 2018 13:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9BBBCE010F for ; Sun, 6 May 2018 13:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C89121298 for ; Sun, 6 May 2018 13:04:00 +0000 (UTC) Date: Sun, 6 May 2018 13:04:00 +0000 (UTC) From: "Shaofeng SHI (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3071) Add config to reuse dict to reduce dict size MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3071?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1646= 5113#comment-16465113 ]=20 Shaofeng SHI commented on KYLIN-3071: ------------------------------------- I think we can enable it by default, this is more useful than growing dict. =C2=A0 [~liyang.gmt8@gmail.com] any concern on it? > Add config to reuse dict to reduce dict size=20 > --------------------------------------------- > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement > Components: Metadata > Reporter: Yang Hao > Assignee: Yang Hao > Priority: Major > Fix For: Future > > Attachments: KYLIN-3071.apache-master.001.patch > > > When calling DictionaryManager.trySaveNewDict, and growing dict is not en= abled, it only use the history dict which is equal, it may generate many di= ct. We should supply a config to use contains instead of equal to reuse old= dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)