kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute
Date Tue, 29 May 2018 04:49:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493103#comment-16493103
] 

ASF GitHub Bot commented on KYLIN-3295:
---------------------------------------

coveralls commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-392651792
 
 
   ## Pull Request Test Coverage Report for [Build 3181](https://coveralls.io/builds/17205617)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.02%**) to **23.914%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/17205617/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L317)
| 1 | 81.08% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/17205617/badge)](https://coveralls.io/builds/17205617)
|
   | :-- | --: |
   | Change from base [Build 3180](https://coveralls.io/builds/17204937): |  0.02% |
   | Covered Lines: | 14267 |
   | Relevant Lines: | 59660 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---------------------------------------------------
>
>                 Key: KYLIN-3295
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3295
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>             Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>        T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message